Add recommended extension installation support

chrome/browser/ui/webui/extensions/extension_settings_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
 
 #include "apps/app_load_service.h"
 #include "apps/saved_files_service.h"
 #include "base/auto_reset.h"
 #include "base/base64.h"
@@ skipping 220 matching lines @@
     should_do_verification_check_ = true;
 
   bool corrupt_install =
       (disable_reasons & Extension::DISABLE_CORRUPTED) != 0;
   extension_data->SetBoolean("corruptInstall", corrupt_install);
 
   bool managed_install =
       !management_policy_->UserMayModifySettings(extension, NULL);
   extension_data->SetBoolean("managedInstall", managed_install);
 
+  bool recommended_install =
+      !managed_install &&
+      management_policy_->MustRemainInstalled(extension, NULL);

[Joao da Silva, 2014/09/18 12:21:23]

This is conflating logic for different things. It would be much clearer if
management_policy_ simply had 2 new calls: IsManagedInstall() and
IsRecommendedInstall()

[binjin, 2014/09/18 16:25:16]

How about management_policy_->UserMayModifySettings() &&
management_policy_->MustRemainInstalled?

[binjin, 2014/09/18 17:44:07]

Okay, I got what you mean. But I still don't think it's a good idea to modify
interfaces of ManagementPolicy. What do you think of accessing
ExtensinManagement service here?

[Joao da Silva, 2014/09/19 07:55:52]

The point is that ManagementPolicy has more than one provider (including
supervised users, device local accounts, and the normal policy source). This
code must handle extensions that are forced-installed from any of those
providers.

So I really think the right fix is to let the ManagementPolicy class tell
exactly: is this extension a mandatory or a recommended install.

Anyway, I think the current code is fine but a bit subtle. It's not a big
problem for now.

+  extension_data->SetBoolean("recommendedInstall", recommended_install);
+
   // We should not get into a state where both are true.
-  DCHECK(!managed_install || !suspicious_install);
+  DCHECK(!(managed_install || recommended_install) || !suspicious_install);
 
   GURL icon =
       ExtensionIconSource::GetIconURL(extension,
                                       extension_misc::EXTENSION_ICON_MEDIUM,
                                       ExtensionIconSet::MATCH_BIGGER,
                                       !enabled, NULL);
   if (Manifest::IsUnpackedLocation(extension->location())) {
     extension_data->SetString("path", extension->path().value());
     extension_data->SetString(
         "prettifiedPath",
@@ skipping 50 matching lines @@
        util::AllowedScriptingOnAllUrls(
            extension->id(), extension_service_->GetBrowserContext()));
   extension_data->SetBoolean("wantsAllUrls", wants_all_urls);
   extension_data->SetBoolean(
       "allowAllUrls",
       util::AllowedScriptingOnAllUrls(
           extension->id(),
           extension_service_->GetBrowserContext()));
 
   base::string16 location_text;
-  if (Manifest::IsPolicyLocation(extension->location())) {
+  if (Manifest::IsPolicyLocation(extension->location()) ||
+      extension->location() == Manifest::EXTERNAL_PREF_DOWNLOAD &&
+          recommended_install) {
     location_text = l10n_util::GetStringUTF16(
         IDS_OPTIONS_INSTALL_LOCATION_ENTERPRISE);
   } else if (extension->location() == Manifest::INTERNAL &&
       !ManifestURL::UpdatesFromGallery(extension)) {
     location_text = l10n_util::GetStringUTF16(
         IDS_OPTIONS_INSTALL_LOCATION_UNKNOWN);
   } else if (extension->location() == Manifest::EXTERNAL_REGISTRY) {
     location_text = l10n_util::GetStringUTF16(
         IDS_OPTIONS_INSTALL_LOCATION_3RD_PARTY);
   } else if (extension->is_shared_module()) {
@@ skipping 1092 matching lines @@
     extension_service_->EnableExtension(extension_id);
   } else {
     ExtensionErrorReporter::GetInstance()->ReportError(
         base::UTF8ToUTF16(JoinString(requirement_errors, ' ')),
         true);  // Be noisy.
   }
   requirements_checker_.reset();
 }
 
 }  // namespace extensions