chrome/browser/resources/options/clear_browser_data_overlay.js - Issue 536703002: Get rid of some <label for> misuse in browser_options.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/clear_browser_data_overlay.js

Issue 536703002: Get rid of some <label for> misuse in browser_options.html (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/browser_options.html ('k') | chrome/browser/resources/options/controlled_setting.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/clear_browser_data_overlay.js

diff --git a/chrome/browser/resources/options/clear_browser_data_overlay.js b/chrome/browser/resources/options/clear_browser_data_overlay.js

index 679de21352bd6f02ac47aedfab42f8cfee274c28..4684943bcde4219eb236b60dc775a6eaa117dad2 100644

--- a/chrome/browser/resources/options/clear_browser_data_overlay.js

+++ b/chrome/browser/resources/options/clear_browser_data_overlay.js

@@ -120,8 +120,8 @@ cr.define('options', function() {

if (buttonId != '') {

var button = document.createElement('button');

- button.setAttribute('id', buttonId);

- button.setAttribute('class', 'link-button');

+ button.id = buttonId;

+ button.className = 'link-button';

button.textContent = footerFragments[i + 1];

footer.appendChild(button);

i += 3;

« no previous file with comments | « chrome/browser/resources/options/browser_options.html ('k') | chrome/browser/resources/options/controlled_setting.css » ('j') | no next file with comments »