Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: chrome/browser/resources/options/clear_browser_data_overlay.js

Issue 536703002: Get rid of some <label for> misuse in browser_options.html (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix related css Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 var Page = cr.ui.pageManager.Page; 6 var Page = cr.ui.pageManager.Page;
7 var PageManager = cr.ui.pageManager.PageManager; 7 var PageManager = cr.ui.pageManager.PageManager;
8 8
9 /** 9 /**
10 * ClearBrowserDataOverlay class 10 * ClearBrowserDataOverlay class
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 if (footerFragments[i] == '|' && footerFragments[i + 2] == '|') { 113 if (footerFragments[i] == '|' && footerFragments[i + 2] == '|') {
114 buttonId = 'open-content-settings-from-clear-browsing-data'; 114 buttonId = 'open-content-settings-from-clear-browsing-data';
115 } else if (footerFragments[i] == '#' && 115 } else if (footerFragments[i] == '#' &&
116 footerFragments[i + 2] == '#') { 116 footerFragments[i + 2] == '#') {
117 buttonId = 'open-search-engines-from-clear-browsing-data'; 117 buttonId = 'open-search-engines-from-clear-browsing-data';
118 } 118 }
119 } 119 }
120 120
121 if (buttonId != '') { 121 if (buttonId != '') {
122 var button = document.createElement('button'); 122 var button = document.createElement('button');
123 button.setAttribute('id', buttonId); 123 button.id = buttonId;
124 button.setAttribute('class', 'link-button'); 124 button.className = 'link-button';
125 button.textContent = footerFragments[i + 1]; 125 button.textContent = footerFragments[i + 1];
126 footer.appendChild(button); 126 footer.appendChild(button);
127 i += 3; 127 i += 3;
128 } else { 128 } else {
129 var span = document.createElement('span'); 129 var span = document.createElement('span');
130 span.textContent = footerFragments[i]; 130 span.textContent = footerFragments[i];
131 footer.appendChild(span); 131 footer.appendChild(span);
132 i += 1; 132 i += 1;
133 } 133 }
134 } 134 }
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 var topmostVisiblePage = PageManager.getTopmostVisiblePage(); 258 var topmostVisiblePage = PageManager.getTopmostVisiblePage();
259 if (topmostVisiblePage && topmostVisiblePage.name == 'clearBrowserData') 259 if (topmostVisiblePage && topmostVisiblePage.name == 'clearBrowserData')
260 PageManager.closeOverlay(); 260 PageManager.closeOverlay();
261 }; 261 };
262 262
263 // Export 263 // Export
264 return { 264 return {
265 ClearBrowserDataOverlay: ClearBrowserDataOverlay 265 ClearBrowserDataOverlay: ClearBrowserDataOverlay
266 }; 266 };
267 }); 267 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698