components/feedback/feedback_uploader.cc - Issue 536623003: Fixups in components/ for scoped_refptr operator T* removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/feedback/feedback_uploader.cc

Issue 536623003: Fixups in components/ for scoped_refptr operator T* removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/feedback/feedback_uploader.h ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/feedback/feedback_uploader.cc

diff --git a/components/feedback/feedback_uploader.cc b/components/feedback/feedback_uploader.cc

index 01a0d0b44f088df095f4c5e31b75a76f9ad8b608..b79ece26d961ef258b546e8728419c208aafb740 100644

--- a/components/feedback/feedback_uploader.cc

+++ b/components/feedback/feedback_uploader.cc

@@ -26,7 +26,8 @@ const base::FilePath::CharType kFeedbackReportPath[] =

} // namespace

bool FeedbackUploader::ReportsUploadTimeComparator::operator()(

- FeedbackReport* a, FeedbackReport* b) const {

+ const scoped_refptr<FeedbackReport>& a,

+ const scoped_refptr<FeedbackReport>& b) const {

return a->upload_at() > b->upload_at();

}

« no previous file with comments | « components/feedback/feedback_uploader.h ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »