Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 536623003: Fixups in components/ for scoped_refptr operator T* removal. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
Cait (Slow), rpaquay
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixups in components/ for scoped_refptr operator T* removal. BUG=110610 TBR=rpaquay@chromium.org Committed: https://crrev.com/972bc39f4a28fa510bfb8c61f94e2e9b1897790f Cr-Commit-Position: refs/heads/master@{#293255}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M components/captive_portal/captive_portal_detector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/feedback/feedback_uploader.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/feedback/feedback_uploader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_manager_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/pdf/renderer/ppb_pdf_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/usb/usb_device_handle_impl.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M device/usb/usb_service_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
dcheng
All pretty straightforward fixes. This is just some of the remainders that the tool was ...
6 years, 3 months ago (2014-09-02 23:49:24 UTC) #2
Cait (Slow)
lgtm
6 years, 3 months ago (2014-09-03 20:35:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/536623003/1
6 years, 3 months ago (2014-09-03 21:21:29 UTC) #5
commit-bot: I haz the power
Failed to apply patch for components/usb_service/usb_device_handle_impl.cc: While running git apply --index -p1; error: components/usb_service/usb_device_handle_impl.cc: does ...
6 years, 3 months ago (2014-09-04 01:36:15 UTC) #7
dcheng
TBRing rpaquay@chromium.org for file that moved to device/ while this CL was in the CQ.
6 years, 3 months ago (2014-09-04 01:43:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/536623003/20001
6 years, 3 months ago (2014-09-04 01:45:15 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1916)
6 years, 3 months ago (2014-09-04 02:28:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/536623003/20001
6 years, 3 months ago (2014-09-04 02:59:04 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1972)
6 years, 3 months ago (2014-09-04 03:41:19 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/536623003/20001
6 years, 3 months ago (2014-09-04 03:58:39 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 77ca37347b1b5bd7b6c225926ae2f5aed34ee405
6 years, 3 months ago (2014-09-04 04:23:48 UTC) #20
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:29:39 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/972bc39f4a28fa510bfb8c61f94e2e9b1897790f
Cr-Commit-Position: refs/heads/master@{#293255}

Powered by Google App Engine
This is Rietveld 408576698