Issue 536593004: Revert "Merge 281715 "[Android WebView] Terminate execution of stuck JS ...""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 536593004: Revert "Merge 281715 "[Android WebView] Terminate execution of stuck JS ..."" (Closed)

Created:
6 years, 3 months ago by mnaganov (inactive)

Modified:
6 years, 3 months ago

Reviewers:

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2062

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Merge 281715 "[Android WebView] Terminate execution of stuck JS ..."" This reverts commit 8508a2f18909b0768d273bb9161aee749f47beca. As described in the bug, the proposed approach is invalid, as Blink's bindings code isn't ready to deal with terminated scripts properly, resulting in random crashes. Hence reverting the patch. BUG=390906 Committed: https://chromium.googlesource.com/chromium/src/+/2222811f02ddd8571625aad74cc945e7ea6763b7

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -256 lines)			Patch
M	android_webview/android_webview.gyp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	android_webview/browser/renderer_host/aw_render_view_host_ext.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	android_webview/browser/renderer_host/aw_render_view_host_ext.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	android_webview/common/render_view_messages.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	android_webview/java/src/org/chromium/android_webview/AwContents.java	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java	View	2 chunks	+0 lines, -70 lines	0 comments	Download
M	android_webview/native/aw_contents.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	android_webview/native/aw_contents.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	android_webview/renderer/aw_content_renderer_client.h	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	android_webview/renderer/aw_content_renderer_client.cc	View	3 chunks	+0 lines, -13 lines	0 comments	Download
D	android_webview/renderer/aw_execution_termination_filter.h	View	1 chunk	+0 lines, -64 lines	0 comments	Download
D	android_webview/renderer/aw_execution_termination_filter.cc	View	1 chunk	+0 lines, -76 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

6 years, 3 months ago (2014-09-03 17:01:16 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 2222811.

Expand Messages | Collapse Messages