Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: pkg/analysis_server/test/domain_completion_test.dart

Issue 536593002: return correct replacementOffset and replacementLength (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/domain_completion_test.dart
diff --git a/pkg/analysis_server/test/domain_completion_test.dart b/pkg/analysis_server/test/domain_completion_test.dart
index 4284706a711e5009451dc691861f55815c91c0bb..7abd76a8501edb84e4833d927d72594865351082 100644
--- a/pkg/analysis_server/test/domain_completion_test.dart
+++ b/pkg/analysis_server/test/domain_completion_test.dart
@@ -161,11 +161,10 @@ class CompletionTest extends AbstractAnalysisTest {
}
test_keyword() {
- addTestFile('^');
+ addTestFile('library A; cl^');
return getSuggestions().then((_) {
- expect(replacementOffset, equals(completionOffset));
- expect(replacementLength, equals(0));
- assertHasResult(CompletionSuggestionKind.KEYWORD, 'library');
+ expect(replacementOffset, equals(completionOffset - 2));
+ expect(replacementLength, equals(2));
assertHasResult(CompletionSuggestionKind.KEYWORD, 'import');
assertHasResult(CompletionSuggestionKind.KEYWORD, 'class');
});
@@ -199,8 +198,8 @@ class CompletionTest extends AbstractAnalysisTest {
main() {tes^t}
''');
return getSuggestions().then((_) {
-// expect(replacementOffset, equals(completionOffset - 3));
-// expect(replacementLength, equals(4));
+ expect(replacementOffset, equals(completionOffset - 3));
+ expect(replacementLength, equals(4));
assertHasResult(CompletionSuggestionKind.CLASS, 'Object');
assertHasResult(CompletionSuggestionKind.TOP_LEVEL_VARIABLE, 'test');
assertNoResult('HtmlElement');
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698