Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 536533004: Android: Remove more browser extensions code, and fullscreen ui. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
scheib
CC:
chromium-reviews, marja+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ext_browser_clean
Project:
chromium
Visibility:
Public.

Description

Android: Remove more browser extensions code, and fullscreen ui. Committed: https://crrev.com/2dbee717e9264c1e074b2437f485e203235f08e8 Cr-Commit-Position: refs/heads/master@{#293521}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -37 lines) Patch
M chrome/browser/chrome_browser_main.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 10 chunks +17 lines, -13 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service_helper.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 8 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +4 lines, -4 lines 1 comment Download

Messages

Total messages: 12 (4 generated)
Lei Zhang
6 years, 3 months ago (2014-09-03 02:50:37 UTC) #2
scheib
lgtm https://codereview.chromium.org/536533004/diff/1/chrome/chrome_browser_ui.gypi File chrome/chrome_browser_ui.gypi (right): https://codereview.chromium.org/536533004/diff/1/chrome/chrome_browser_ui.gypi#newcode1438 chrome/chrome_browser_ui.gypi:1438: 'browser/ui/fullscreen/fullscreen_exit_bubble.cc', This is not extensions related, I've updated ...
6 years, 3 months ago (2014-09-04 17:38:14 UTC) #3
Lei Zhang
On 2014/09/04 17:38:14, scheib wrote: > lgtm > > https://codereview.chromium.org/536533004/diff/1/chrome/chrome_browser_ui.gypi > File chrome/chrome_browser_ui.gypi (right): > ...
6 years, 3 months ago (2014-09-04 17:40:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/536533004/1
6 years, 3 months ago (2014-09-04 17:50:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/10213)
6 years, 3 months ago (2014-09-04 21:54:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/536533004/1
6 years, 3 months ago (2014-09-05 14:52:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 15b40fd3f60cca14ea7a502be8179c9f7532c0a2
6 years, 3 months ago (2014-09-05 14:55:08 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:39:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2dbee717e9264c1e074b2437f485e203235f08e8
Cr-Commit-Position: refs/heads/master@{#293521}

Powered by Google App Engine
This is Rietveld 408576698