Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 536453007: Add truncation to StreamCopyOrMoveImpl and test case. (Closed)

Created:
6 years, 3 months ago by iseki
Modified:
6 years, 3 months ago
Reviewers:
tzik
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add truncation to StreamCopyOrMoveImpl and test case. BUG=410126 TEST=content_unittests Committed: https://crrev.com/e5ce274558eaf7231b9294318cc1db2bd9c553ba Cr-Commit-Position: refs/heads/master@{#293082}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -2 lines) Patch
M content/browser/fileapi/file_system_operation_impl_unittest.cc View 1 2 chunks +39 lines, -0 lines 0 comments Download
M webkit/browser/fileapi/copy_or_move_operation_delegate.cc View 1 2 chunks +31 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
iseki
Please take a look.
6 years, 3 months ago (2014-09-03 01:59:27 UTC) #2
tzik
https://codereview.chromium.org/536453007/diff/1/content/browser/fileapi/file_system_operation_impl_unittest.cc File content/browser/fileapi/file_system_operation_impl_unittest.cc (right): https://codereview.chromium.org/536453007/diff/1/content/browser/fileapi/file_system_operation_impl_unittest.cc#newcode1302 content/browser/fileapi/file_system_operation_impl_unittest.cc:1302: base::RunLoop().RunUntilIdle(); This doesn't run the modified part of the ...
6 years, 3 months ago (2014-09-03 02:07:43 UTC) #3
iseki
Thank you for your review:) https://codereview.chromium.org/536453007/diff/1/content/browser/fileapi/file_system_operation_impl_unittest.cc File content/browser/fileapi/file_system_operation_impl_unittest.cc (right): https://codereview.chromium.org/536453007/diff/1/content/browser/fileapi/file_system_operation_impl_unittest.cc#newcode1302 content/browser/fileapi/file_system_operation_impl_unittest.cc:1302: base::RunLoop().RunUntilIdle(); On 2014/09/03 02:07:43, ...
6 years, 3 months ago (2014-09-03 03:28:21 UTC) #4
tzik
lgtm
6 years, 3 months ago (2014-09-03 04:26:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/536453007/20001
6 years, 3 months ago (2014-09-03 05:09:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 2bdf4486ff836859b682b5cde420be5cbf8f2bbb
6 years, 3 months ago (2014-09-03 06:12:54 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:23:54 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5ce274558eaf7231b9294318cc1db2bd9c553ba
Cr-Commit-Position: refs/heads/master@{#293082}

Powered by Google App Engine
This is Rietveld 408576698