Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 536393003: Enforce correct number comparisons when inlining Array.indexOf. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Enforce correct number comparisons when inlining Array.indexOf. TEST=mjsunit/regress/regress-crbug-407946 BUG=407946 LOG=y R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23691

Patch Set 1 #

Patch Set 2 : Fix regression test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M src/hydrogen.cc View 2 chunks +8 lines, -6 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-407946.js View 1 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 3 months ago (2014-09-04 11:53:55 UTC) #1
Toon Verwaest
lgtm
6 years, 3 months ago (2014-09-04 12:17:18 UTC) #2
Benedikt Meurer
6 years, 3 months ago (2014-09-04 12:26:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 23691 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698