Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 536343002: [SyncFS] CountDirtyTracke() does not run a full scan (Closed)

Created:
6 years, 3 months ago by peria
Modified:
6 years, 3 months ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[SyncFS] CountDirtyTracke() does not run a full scan. It reduces disk I/O cost on counting dirty trackers. BUG=347425 TEST=./unit_tests --gtest_filter="MetadataDatabase*" Committed: https://crrev.com/a38fa22d030b7688544a5f41f4fc9a5b5dfe22c2 Cr-Commit-Position: refs/heads/master@{#293447}

Patch Set 1 : #

Patch Set 2 : Move CountDirtyTrackerInternal in .cc #

Patch Set 3 : Do not store on disk #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -18 lines) Patch
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc View 1 2 3 7 chunks +26 lines, -18 lines 0 comments Download

Messages

Total messages: 31 (13 generated)
peria
PTL
6 years, 3 months ago (2014-09-04 06:46:03 UTC) #4
tzik
Can we just hold it on memory..?
6 years, 3 months ago (2014-09-04 06:48:44 UTC) #5
peria
On 2014/09/04 06:48:44, tzik wrote: > Can we just hold it on memory..? Yes, we ...
6 years, 3 months ago (2014-09-04 06:50:41 UTC) #6
peria
On 2014/09/04 06:50:41, peria wrote: > On 2014/09/04 06:48:44, tzik wrote: > > Can we ...
6 years, 3 months ago (2014-09-04 06:59:42 UTC) #7
tzik
lgtm
6 years, 3 months ago (2014-09-04 07:05:22 UTC) #8
nhiroki
lgtm
6 years, 3 months ago (2014-09-04 07:11:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/536343002/80001
6 years, 3 months ago (2014-09-04 07:13:34 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2059)
6 years, 3 months ago (2014-09-04 08:06:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/536343002/80001
6 years, 3 months ago (2014-09-04 08:08:00 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2080)
6 years, 3 months ago (2014-09-04 08:53:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/536343002/80001
6 years, 3 months ago (2014-09-04 09:32:18 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/47826)
6 years, 3 months ago (2014-09-04 20:28:55 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/536343002/80001
6 years, 3 months ago (2014-09-05 02:00:24 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/47826)
6 years, 3 months ago (2014-09-05 03:03:32 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/536343002/80001
6 years, 3 months ago (2014-09-05 03:30:13 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/536343002/100001
6 years, 3 months ago (2014-09-05 03:39:46 UTC) #29
commit-bot: I haz the power
Committed patchset #4 (id:100001) as b23dbc0aea7ed99b06a5cdddb3349c258b295347
6 years, 3 months ago (2014-09-05 05:05:45 UTC) #30
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:37:05 UTC) #31
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a38fa22d030b7688544a5f41f4fc9a5b5dfe22c2
Cr-Commit-Position: refs/heads/master@{#293447}

Powered by Google App Engine
This is Rietveld 408576698