Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 536313002: Revert of Removing X11 native_event uses for key events. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, ben+ash_chromium.org, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, Elliot Glaysher, jam, kalyank, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, sadrul, tdresser+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Removing X11 native_event uses for key events. (patchset #6 id:160001 of https://codereview.chromium.org/479873002/) Reason for revert: Causing check_licenses to fail on android_clang_dbg_recipe trybot: The following files are whitelisted unnecessarily. You must remove the following files from the whitelist. content/browser/renderer_host/web_input_event_aurax11.cc The following files are whitelisted, but do not exist. content/browser/renderer_host/web_input_event_aurax11.cc Original issue's description: > Removing uses of X11 native key events. > > BUG=380349 > > Committed: https://chromium.googlesource.com/chromium/src/+/bbb7ea7c66f18298079eea4a6b24834986f4a822 TBR=sadrul@chromium.org,sky@chromium.org,erg@chromium.org,jamesr@chromium.org,kpschoedel@chromium.org NOTREECHECKS=true NOTRY=true BUG=380349 Committed: https://crrev.com/97b7fc9ff9b9eade1654f1394b5992c2c2a17ef9 Cr-Commit-Position: refs/heads/master@{#293254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -185 lines) Patch
M ash/accelerators/key_hold_detector.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 4 chunks +30 lines, -11 lines 0 comments Download
A content/browser/renderer_host/web_input_event_aurax11.cc View 1 chunk +96 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 2 chunks +14 lines, -11 lines 0 comments Download
M mojo/services/native_viewport/platform_viewport_x11.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/public/cpp/input_events/lib/input_events_type_converters.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M ui/events/event.h View 5 chunks +2 lines, -31 lines 0 comments Download
M ui/events/event.cc View 7 chunks +7 lines, -110 lines 0 comments Download
M ui/events/event_utils.h View 2 chunks +19 lines, -4 lines 0 comments Download
M ui/events/event_utils.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/events/ozone/events_ozone.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M ui/events/win/events_win.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M ui/events/x/events_x.cc View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dcheng
Created Revert of Removing X11 native_event uses for key events.
6 years, 3 months ago (2014-09-04 03:50:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/536313002/1
6 years, 3 months ago (2014-09-04 03:50:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5e96641ef9b0d92a2475c82f4b2f7067e0d7175b
6 years, 3 months ago (2014-09-04 03:53:09 UTC) #3
dcheng
One of many failures can be seen at http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1975
6 years, 3 months ago (2014-09-04 03:53:37 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:29:37 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97b7fc9ff9b9eade1654f1394b5992c2c2a17ef9
Cr-Commit-Position: refs/heads/master@{#293254}

Powered by Google App Engine
This is Rietveld 408576698