Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 536283002: Disable low res tilings on desktop. (Closed)

Created:
6 years, 3 months ago by danakj
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
enne (OOO), chromium-reviews, darin-cc_chromium.org, jam, piman, reveman, vmpstr, ernstm, Vangelis Kokkevis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable low res tilings on desktop. Stop creating low res tilings in the compositor on non-Android platforms. The command line flags still exist to override this behaviour. Android will continue to use low res tilings by default. BUG=410610, 407121 Committed: https://crrev.com/a3e727222442a84542c508bf9b436691a217e08d Cr-Commit-Position: refs/heads/master@{#293858}

Patch Set 1 #

Patch Set 2 : nolowres: androidkeeps #

Patch Set 3 : nolowres: rebase #

Patch Set 4 : nolowres: compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 3 chunks +8 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
danakj
6 years, 3 months ago (2014-09-04 01:08:38 UTC) #2
jamesr
lgtm to try this out
6 years, 3 months ago (2014-09-04 04:11:04 UTC) #3
danakj
james can you PTAL? I updated the CL to only disable low res on !ANDROID. ...
6 years, 3 months ago (2014-09-08 22:22:20 UTC) #4
jamesr
Please update the patch description. I believe what you've implemented changes the default on non-android ...
6 years, 3 months ago (2014-09-08 22:24:54 UTC) #5
danakj
On Mon, Sep 8, 2014 at 6:24 PM, <jamesr@chromium.org> wrote: > Please update the patch ...
6 years, 3 months ago (2014-09-08 22:25:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/536283002/60001
6 years, 3 months ago (2014-09-08 22:31:46 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001) as c3bb163ffdadc4bfa92942a29bd8bfcb270a1e1c
6 years, 3 months ago (2014-09-09 05:42:43 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:50:40 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a3e727222442a84542c508bf9b436691a217e08d
Cr-Commit-Position: refs/heads/master@{#293858}

Powered by Google App Engine
This is Rietveld 408576698