runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart - Issue 536273002: Teach the Observatory about WeakProperties (ephemerons).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart

Issue 536273002: Teach the Observatory about WeakProperties (ephemerons). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: build Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart ('k') | runtime/bin/vmservice/observatory/lib/src/service/object.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart

diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart b/runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart

index 0864e32e3a91408f79aaabf6c6bcf47d3a7bf6ee..15da1b8236497baff1389eae43a46640f9cef39c 100644

--- a/runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart

+++ b/runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart

@@ -76,7 +76,6 @@ class ServiceObjectViewElement extends ObservatoryElement {

case 'SendPort':

case 'Stacktrace':

case 'JSRegExp':

- case 'WeakProperty':

case 'UserTag':

// TODO(turnidge): The types above this comment are instance

// types and should be handled by the InstanceViewElement. We

@@ -95,6 +94,7 @@ class ServiceObjectViewElement extends ObservatoryElement {

case 'Null':

case 'Bigint':

case 'String':

+ case 'WeakProperty':

InstanceViewElement element = new Element.tag('instance-view');

element.instance = object;

return element;