Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 536243002: [telemetry] Add WinRing0/MSR power monitor. (Closed)

Created:
6 years, 3 months ago by dtu
Modified:
6 years, 3 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Add WinRing0/MSR power monitor. This is a power monitor that reads the Intel RAPL MSRs to get energy measurements. It uses a defunct open source DLL and kernel driver, WinRing0, to access the MSRs. WinRing0 is a little wonky, and we have to install the kernel driver to the Python executable's directory. Python must be run as Administrator for this to work. BUG=336558 TEST=tools/telemetry/run_tests winring0 Committed: https://crrev.com/10d4df165c5ce09503738fdd0549b5287c00d713 Cr-Commit-Position: refs/heads/master@{#293277}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Rename to Msr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -32 lines) Patch
A tools/telemetry/bin/win/winring0.zip.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py View 1 2 1 chunk +175 lines, -0 lines 0 comments Download
A + tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor_unittest.py View 1 2 1 chunk +31 lines, -30 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/win_platform_backend.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
dtu
6 years, 3 months ago (2014-09-03 23:44:05 UTC) #2
tonyg
lgtm https://codereview.chromium.org/536243002/diff/20001/tools/telemetry/telemetry/core/platform/power_monitor/winring0_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/winring0_power_monitor.py (right): https://codereview.chromium.org/536243002/diff/20001/tools/telemetry/telemetry/core/platform/power_monitor/winring0_power_monitor.py#newcode119 tools/telemetry/telemetry/core/platform/power_monitor/winring0_power_monitor.py:119: class WinRing0PowerMonitor(power_monitor.PowerMonitor): Should we consider calling this MsrPowerMonitor ...
6 years, 3 months ago (2014-09-04 00:07:07 UTC) #3
dtu
https://chromiumcodereview.appspot.com/536243002/diff/20001/tools/telemetry/telemetry/core/platform/power_monitor/winring0_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/winring0_power_monitor.py (right): https://chromiumcodereview.appspot.com/536243002/diff/20001/tools/telemetry/telemetry/core/platform/power_monitor/winring0_power_monitor.py#newcode119 tools/telemetry/telemetry/core/platform/power_monitor/winring0_power_monitor.py:119: class WinRing0PowerMonitor(power_monitor.PowerMonitor): On 2014/09/04 00:07:07, tonyg wrote: > Should ...
6 years, 3 months ago (2014-09-04 00:59:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/536243002/40001
6 years, 3 months ago (2014-09-04 01:02:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1936)
6 years, 3 months ago (2014-09-04 02:58:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/536243002/40001
6 years, 3 months ago (2014-09-04 06:25:16 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 1f745bba63c18483a8f3c58464bcb01940adb04b
6 years, 3 months ago (2014-09-04 06:59:32 UTC) #11
henrika (OOO until Aug 14)
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/547343003/ by henrika@chromium.org. ...
6 years, 3 months ago (2014-09-08 09:37:22 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:30:32 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/10d4df165c5ce09503738fdd0549b5287c00d713
Cr-Commit-Position: refs/heads/master@{#293277}

Powered by Google App Engine
This is Rietveld 408576698