chrome/browser/extensions/global_shortcut_listener_chromeos.cc - Issue 536233002: Begin introducing some of the initial pieces for ChromeVox next commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/global_shortcut_listener_chromeos.cc

Issue 536233002: Begin introducing some of the initial pieces for ChromeVox next commands. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@chromeos_conversions

Patch Set: Address comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/chromevox/injected/init_document.js » ('j') | chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/global_shortcut_listener_chromeos.cc

diff --git a/chrome/browser/extensions/global_shortcut_listener_chromeos.cc b/chrome/browser/extensions/global_shortcut_listener_chromeos.cc

index ec211249cc13166ba9c4214d1a02e332a48b48f7..77eebf85a2bdf997a409b0124d215da0479e4323 100644

--- a/chrome/browser/extensions/global_shortcut_listener_chromeos.cc

+++ b/chrome/browser/extensions/global_shortcut_listener_chromeos.cc

@@ -99,6 +99,7 @@ void GlobalShortcutListenerChromeOS::UnregisterAcceleratorImpl(

bool GlobalShortcutListenerChromeOS::AcceleratorPressed(

const ui::Accelerator& accelerator) {

+ LOG(ERROR) << "processing!";

Peter Lundblad 2014/09/05 07:21:54 Don't forget this one.

David Tseng 2014/09/08 19:24:34 Rebasing/rietveld showing upstream for whatever re

DCHECK(is_listening_);

ash::AcceleratorController* controller =

ash::Shell::GetInstance()->accelerator_controller();