Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 536213003: Whitelisting Shout Out extension for chrome.copresence. (Closed)

Created:
6 years, 3 months ago by Boris Smus
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Whitelisting Shout Out extension for chrome.copresence. BUG=409192 R=rkc, xiaowenx Committed: https://crrev.com/8bf7cfffd01ed9c1e7cfdee389f70c3b4ecb15e4 Cr-Commit-Position: refs/heads/master@{#294949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/common/extensions/api/_permission_features.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Boris Smus
6 years, 3 months ago (2014-09-04 01:31:25 UTC) #1
rkc
This needs to be reviewed by an apps team owner; adding asargent@ for the review. ...
6 years, 3 months ago (2014-09-04 01:37:31 UTC) #3
rkc
Both kalman and asargent are OOO, adding miket@ for the review.
6 years, 3 months ago (2014-09-04 12:38:35 UTC) #5
Boris Smus
Bump, any news on this? Would be good to land at some point so that ...
6 years, 3 months ago (2014-09-09 21:20:05 UTC) #6
rkc
Adding more owners from c/b/e
6 years, 3 months ago (2014-09-15 21:57:05 UTC) #8
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-15 22:02:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/536213003/1
6 years, 3 months ago (2014-09-15 22:56:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 72f26b0a06d43a9ac2daad03256ea5fa3c7a526c
6 years, 3 months ago (2014-09-16 00:52:44 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 00:54:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bf7cfffd01ed9c1e7cfdee389f70c3b4ecb15e4
Cr-Commit-Position: refs/heads/master@{#294949}

Powered by Google App Engine
This is Rietveld 408576698