Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 536203002: Mark the root GN build target as test only. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@pullgn
Project:
chromium
Visibility:
Public.

Description

Mark the root GN build target as test only. This will allow us to mark other things as tests as well. Committed: https://crrev.com/b80a148ef40a2328b63a9a51f0bfe2fb3270ced7 Cr-Commit-Position: refs/heads/master@{#293309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
Turns out this one needs to go first, then all_blink, then a blink roll, then ...
6 years, 3 months ago (2014-09-03 22:33:21 UTC) #2
viettrungluu
lgtm
6 years, 3 months ago (2014-09-03 22:55:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/536203002/1
6 years, 3 months ago (2014-09-04 03:10:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/12082)
6 years, 3 months ago (2014-09-04 03:24:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/536203002/1
6 years, 3 months ago (2014-09-04 16:29:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 78fcd8c02c4de21050af9944d5db7e17be9859b0
6 years, 3 months ago (2014-09-04 17:02:31 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:31:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b80a148ef40a2328b63a9a51f0bfe2fb3270ced7
Cr-Commit-Position: refs/heads/master@{#293309}

Powered by Google App Engine
This is Rietveld 408576698