Stopgap fix for crash in issue 53867 comment 15

webkit/glue/webmediaplayer_impl.h

Index: webkit/glue/webmediaplayer_impl.h
diff --git a/webkit/glue/webmediaplayer_impl.h b/webkit/glue/webmediaplayer_impl.h
index 9361020ea1a35cb2f2ef3fe1775e70d9d195ec7b..d4df24b4af6a57fcff5910101db6a42ecc9fb411 100644
--- a/webkit/glue/webmediaplayer_impl.h
+++ b/webkit/glue/webmediaplayer_impl.h
@@ -169,14 +169,18 @@ class WebMediaPlayerImpl : public WebKit::WebMediaPlayer,
   // |collection| can override the default filters by adding extra filters to
   // |collection| before calling this method.
   //
+  // Callers must call |initialization()| before they can use the object.

[scherkus (not reviewing), 2010/12/01 06:37:55]

|initialization()| -> initialize()

[Nico, 2010/12/01 06:46:04]

Done.

   WebMediaPlayerImpl(WebKit::WebMediaPlayerClient* client,
-                     media::MediaFilterCollection* collection,
-                     MediaResourceLoaderBridgeFactory* bridge_factory_simple,
-                     MediaResourceLoaderBridgeFactory* bridge_factory_buffered,
-                     bool use_simple_data_source,
-                     scoped_refptr<WebVideoRenderer> web_video_renderer);
+                     media::MediaFilterCollection* collection);
   virtual ~WebMediaPlayerImpl();
 
+  // Finalizes initialization of the object.
+  bool initialize(

[scherkus (not reviewing), 2010/12/01 06:37:55]

nit: actually this method can be Chromium styled (i.e., Initialize vs.
initialize)

the camelCase methods are due to implementing WebMediaPlayer interface, but
since we don't really want to have to change that interface we can simply go
with Initialize() with a capital I

[Nico, 2010/12/01 06:46:04]

Done.

+    MediaResourceLoaderBridgeFactory* bridge_factory_simple,

[scherkus (not reviewing), 2010/12/01 06:37:55]

nit: indent by 4 spaces

[Nico, 2010/12/01 06:46:04]

Done.

+    MediaResourceLoaderBridgeFactory* bridge_factory_buffered,
+    bool use_simple_data_source,
+    scoped_refptr<WebVideoRenderer> web_video_renderer);
+
   virtual void load(const WebKit::WebURL& url);
   virtual void cancelLoad();