Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 536153002: mojo: Fix window resizing in mojo_sample_app and mojo_demo_launcher. (Closed)

Created:
6 years, 3 months ago by Elliot Glaysher
Modified:
6 years, 3 months ago
Reviewers:
jamesr, sky, jbauman
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Fix window resizing in mojo_sample_app and mojo_demo_launcher. These ended up having different bugs in different apps. In the mojo_sample_app, we didn't pass a glResizeCHROMIUM() call on resize. In mojo_demo_launcher, we weren't plumbing events from the aura window hierarchy to the ServerView correctly. BUG=393244 Committed: https://crrev.com/6551954469290399d921c1e311c992ee49f1cbd7 Cr-Commit-Position: refs/heads/master@{#293378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M mojo/examples/sample_app/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/examples/sample_app/gles2_client_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M mojo/services/view_manager/display_manager.cc View 5 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Elliot Glaysher
jamesr: sample app sky: view_manager
6 years, 3 months ago (2014-09-03 21:55:54 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-03 22:02:52 UTC) #3
Elliot Glaysher
ping james
6 years, 3 months ago (2014-09-04 17:52:34 UTC) #4
jamesr
lgtm
6 years, 3 months ago (2014-09-04 18:25:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/536153002/1
6 years, 3 months ago (2014-09-04 19:08:17 UTC) #7
Elliot Glaysher
+jbauman for gpu owners stamp. This is copying a DEPS rule from other mojo targets.
6 years, 3 months ago (2014-09-04 23:00:21 UTC) #9
jbauman
lgtm
6 years, 3 months ago (2014-09-04 23:01:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 54dd2827bf23620bc6fd3a9d6556ebded255d269
6 years, 3 months ago (2014-09-04 23:57:37 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:34:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6551954469290399d921c1e311c992ee49f1cbd7
Cr-Commit-Position: refs/heads/master@{#293378}

Powered by Google App Engine
This is Rietveld 408576698