content/renderer/p2p/ipc_network_manager.h - Issue 536133003: MergeNetworkList can't group address under the same interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/p2p/ipc_network_manager.h

Issue 536133003: MergeNetworkList can't group address under the same interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix one more comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/p2p/ipc_network_manager.h

diff --git a/content/renderer/p2p/ipc_network_manager.h b/content/renderer/p2p/ipc_network_manager.h

index 4ed3c48a03fbebecb622bf233bc6512d2ec35554..059091321f020ea53855c17c1e7b32fded53dd99 100644

--- a/content/renderer/p2p/ipc_network_manager.h

+++ b/content/renderer/p2p/ipc_network_manager.h

@@ -22,7 +22,8 @@ class IpcNetworkManager : public rtc::NetworkManagerBase,

public NetworkListObserver {

public:

// Constructor doesn't take ownership of the |socket_dispatcher|.

- CONTENT_EXPORT IpcNetworkManager(P2PSocketDispatcher* socket_dispatcher);

+ CONTENT_EXPORT IpcNetworkManager(

+ NetworkListManager* socket_dispatcher);

Sergey Ulanov 2014/09/10 23:37:15 please rename the variable too

guoweis_webrtc 2014/09/11 00:15:31 Done.

virtual ~IpcNetworkManager();

virtual void StartUpdating() OVERRIDE;

@@ -35,7 +36,7 @@ class IpcNetworkManager : public rtc::NetworkManagerBase,

private:

void SendNetworksChangedSignal();

- P2PSocketDispatcher* socket_dispatcher_;

+ NetworkListManager* socket_dispatcher_;

int start_count_;

bool network_list_received_;

« no previous file with comments | « content/content_tests.gypi ('k') | content/renderer/p2p/ipc_network_manager.cc » ('j') | content/renderer/p2p/ipc_network_manager_unittest.cc » ('J')