content/browser/renderer_host/render_widget_host_view_android.cc - Issue 536063002: Clean up RenderWidgetHostView destruction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 536063002: Clean up RenderWidgetHostView destruction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Safer scheme Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index 04792ac51de9b6939c3b8715cb402264c35c40b8..bf76e384b6aaf7a7a79db492eceb49535bd14142 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -734,18 +734,12 @@ void RenderWidgetHostViewAndroid::FocusedNodeChanged(bool is_editable_node) {

selection_controller_->OnSelectionEditable(is_editable_node);

}

-void RenderWidgetHostViewAndroid::RenderProcessGone(

- base::TerminationStatus status, int error_code) {

- Destroy();

void RenderWidgetHostViewAndroid::Destroy() {

RemoveLayers();

SetContentViewCore(NULL);

- // The RenderWidgetHost's destruction led here, so don't call it.

+ host_->ViewDestroyed(this);

host_ = NULL;

delete this;

}