Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: content/browser/renderer_host/render_widget_host_unittest.cc

Issue 536063002: Clean up RenderWidgetHostView destruction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Safer scheme Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_unittest.cc b/content/browser/renderer_host/render_widget_host_unittest.cc
index 6503eeabd0cfee7e47da7749a3e2e8401f414ac3..cdbf083b32e6541bf53a8a408bcc117b0ed26281 100644
--- a/content/browser/renderer_host/render_widget_host_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_unittest.cc
@@ -747,7 +747,7 @@ TEST_F(RenderWidgetHostTest, ResizeThenCrash) {
// Simulate a renderer crash before the update message. Ensure all the
// resize ack logic is cleared. Must clear the view first so it doesn't get
// deleted.
- host_->SetView(NULL);
+ host_->ViewDestroyed(view_.get());
host_->RendererExited(base::TERMINATION_STATUS_PROCESS_CRASHED, -1);
EXPECT_FALSE(host_->resize_ack_pending_);
EXPECT_EQ(gfx::Size(), host_->last_requested_size_);
@@ -784,7 +784,7 @@ TEST_F(RenderWidgetHostTest, Background) {
#if defined(USE_AURA)
// See the comment above |InitAsChild(NULL)|.
- host_->SetView(NULL);
+ host_->ViewDestroyed(view_.get());
static_cast<RenderWidgetHostViewBase*>(view.release())->Destroy();
#endif
}

Powered by Google App Engine
This is Rietveld 408576698