content/browser/renderer_host/render_widget_host_impl.h - Issue 536063002: Clean up RenderWidgetHostView destruction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 536063002: Clean up RenderWidgetHostView destruction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Safer scheme Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_impl.h

diff --git a/content/browser/renderer_host/render_widget_host_impl.h b/content/browser/renderer_host/render_widget_host_impl.h

index 7dba4d20e4799730fd11d2933a1dd2a5e28b3a4c..733bfd68aef8a2d58ff7c82a04ec36fd64e6ee86 100644

--- a/content/browser/renderer_host/render_widget_host_impl.h

+++ b/content/browser/renderer_host/render_widget_host_impl.h

@@ -225,8 +225,10 @@ class CONTENT_EXPORT RenderWidgetHostImpl

// Noifies the RenderWidget of the current mouse cursor visibility state.

void SendCursorVisibilityState(bool is_visible);

- // Notifies the RenderWidgetHost that the View was destroyed.

- void ViewDestroyed();

+ // Notifies the RenderWidgetHost that a given View was destroyed and the

+ // RenderWidgetHost should not access it. It may be that the RenderWidgetHost

+ // had already severed all references to this view.

+ void ViewDestroyed(RenderWidgetHostViewBase* view);

#if defined(OS_MACOSX)

// Pause for a moment to wait for pending repaint or resize messages sent to