Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 536033002: Clean up old field trial activation code. (Closed)

Created:
6 years, 3 months ago by Alexei Svitkine (slow)
Modified:
6 years, 3 months ago
Reviewers:
jwd
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up old field trial activation code. None of these are needed anymore since trials can be marked as "starts_active" server-side. BUG=none Committed: https://crrev.com/b860144c20ad3b3f7ecabacf8f39c9e7924d8e29 Cr-Commit-Position: refs/heads/master@{#293237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/browser/chrome_browser_field_trials.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Alexei Svitkine (slow)
6 years, 3 months ago (2014-09-03 17:43:32 UTC) #2
jwd
LGTM nit: activition -> activation in cl description.
6 years, 3 months ago (2014-09-03 19:29:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/536033002/1
6 years, 3 months ago (2014-09-03 21:21:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 388a143800f22d36c66c9eb97efa5880f6bfc504
6 years, 3 months ago (2014-09-04 00:32:11 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:29:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b860144c20ad3b3f7ecabacf8f39c9e7924d8e29
Cr-Commit-Position: refs/heads/master@{#293237}

Powered by Google App Engine
This is Rietveld 408576698