Fix crash in Cronet CreateUrlRequestAdapter.

components/cronet/android/chromium_url_request.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/cronet/android/chromium_url_request.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/macros.h"
 #include "components/cronet/android/url_request_adapter.h"
@@ skipping 27 matching lines @@
 
 void SetPostContentType(JNIEnv* env,
                         URLRequestAdapter* request,
                         jstring content_type) {
   DCHECK(request != NULL);
 
   std::string method_post("POST");
   request->SetMethod(method_post);
 
   std::string content_type_header("Content-Type");
-
-  const char* content_type_utf8 = env->GetStringUTFChars(content_type, NULL);
-  std::string content_type_string(content_type_utf8);
-  env->ReleaseStringUTFChars(content_type, content_type_utf8);
+  std::string content_type_string(
+      base::android::ConvertJavaStringToUTF8(env, content_type));
 
   request->AddHeader(content_type_header, content_type_string);
 }
 
 // A delegate of URLRequestAdapter that delivers callbacks to the Java layer.
 class JniURLRequestAdapterDelegate
     : public URLRequestAdapter::URLRequestAdapterDelegate {
  public:
   JniURLRequestAdapterDelegate(JNIEnv* env, jobject owner) {
     owner_ = env->NewGlobalRef(owner);
@@ skipping 51 matching lines @@
 
 static jlong CreateRequestAdapter(JNIEnv* env,
                                   jobject object,
                                   jlong urlRequestContextAdapter,
                                   jstring url_string,
                                   jint priority) {
   URLRequestContextAdapter* context =
       reinterpret_cast<URLRequestContextAdapter*>(urlRequestContextAdapter);
   DCHECK(context != NULL);
 
-  const char* url_utf8 = env->GetStringUTFChars(url_string, NULL);
+  GURL url(base::android::ConvertJavaStringToUTF8(env, url_string));
 
-  VLOG(1) << "New chromium network request. URL:" << url_utf8;
-
-  GURL url(url_utf8);
-
-  env->ReleaseStringUTFChars(url_string, url_utf8);
+  VLOG(1) << "New chromium network request: " << url.possibly_invalid_spec();
 
   URLRequestAdapter* adapter =
       new URLRequestAdapter(context,
                             new JniURLRequestAdapterDelegate(env, object),
                             url,
                             ConvertRequestPriority(priority));
 
   return reinterpret_cast<jlong>(adapter);
 }
 
@@ skipping 247 matching lines @@
 
   // Some implementations (notably HttpURLConnection) include a mapping for the
   // null key; in HTTP's case, this maps to the HTTP status line.
   ScopedJavaLocalRef<jstring> status_line =
       ConvertUTF8ToJavaString(env, headers->GetStatusLine());
   Java_ChromiumUrlRequest_onAppendResponseHeader(
       env, object, headersMap, NULL, status_line.Release());
 }
 
 }  // namespace cronet