Fix crash in Cronet CreateUrlRequestAdapter.

components/cronet/android/cronet_jni.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/android/base_jni_registrar.h"
 #include "base/android/jni_android.h"
 #include "base/android/jni_registrar.h"
 #include "base/at_exit.h"
 #include "components/cronet/android/chromium_url_request.h"
 #include "components/cronet/android/chromium_url_request_context.h"
 #include "net/android/net_jni_registrar.h"
 #include "url/android/url_jni_registrar.h"
+#include "url/url_util.h"
 
 #if !defined(USE_ICU_ALTERNATIVES_ON_ANDROID)
 #include "base/i18n/icu_util.h"
 #endif
 
 namespace {
 
 const base::android::RegistrationMethod kCronetRegisteredMethods[] = {
     {"BaseAndroid", base::android::RegisterJni},
     {"ChromiumUrlRequest", cronet::ChromiumUrlRequestRegisterJni},
@@ skipping 19 matching lines @@
           env, kCronetRegisteredMethods, arraysize(kCronetRegisteredMethods))) {
     return -1;
   }
 
   g_at_exit_manager = new base::AtExitManager();
 
 #if !defined(USE_ICU_ALTERNATIVES_ON_ANDROID)
   base::i18n::InitializeICU();
 #endif
 
+  url::Initialize();
+
   return JNI_VERSION_1_6;
 }
 
 extern "C" void JNIEXPORT JNICALL JNI_OnUnLoad(JavaVM* jvm, void* reserved) {
   if (g_at_exit_manager) {
     delete g_at_exit_manager;
     g_at_exit_manager = NULL;
   }
+  url::Shutdown();

[Charles, 2014/09/03 18:28:20]

I don't think this actually ever gets called.
http://bleaklow.com/2006/02/18/jni_onunload_mostly_useless.html

[mef, 2014/09/03 18:32:38]

Yeah, but if it ever does we will do the right thing. :)

[mmenke, 2014/09/03 18:43:06]

Is this the right thing?  Can we be guaranteed that all network threads have
been killed at this point?  I'm not sure we can be, so we may still be calling
into GURL functions, at least destructors.

Seems safer to just leak here.

[mef, 2014/09/03 18:56:04]

Done.

 }