Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3019)

Unified Diff: athena/activity/activity_manager_unittest.cc

Issue 536013002: Decoupling visibility states from webcontent, adding visibility management in ResourceManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « athena/activity/activity_manager_impl.cc ('k') | athena/activity/activity_view_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/activity/activity_manager_unittest.cc
diff --git a/athena/activity/activity_manager_unittest.cc b/athena/activity/activity_manager_unittest.cc
index 4374609fa9ad6f1b5f30348d8e26170c570226e2..5c45c0b85f3e250076c43408e24c50716f145ff7 100644
--- a/athena/activity/activity_manager_unittest.cc
+++ b/athena/activity/activity_manager_unittest.cc
@@ -16,9 +16,9 @@ typedef test::AthenaTestBase ActivityManagerTest;
TEST_F(ActivityManagerTest, Basic) {
ActivityManagerImpl* activity_manager =
static_cast<ActivityManagerImpl*>(ActivityManager::Get());
- scoped_ptr<Activity> activity1(
- athena::ActivityFactory::Get()->CreateWebActivity(NULL, GURL()));
- activity_manager->AddActivity(activity1.get());
+ Activity* activity1 = athena::ActivityFactory::Get()->CreateWebActivity(
+ NULL, GURL());
+ activity_manager->AddActivity(activity1);
EXPECT_EQ(1, activity_manager->num_activities());
Activity* activity2 =
@@ -26,7 +26,7 @@ TEST_F(ActivityManagerTest, Basic) {
activity_manager->AddActivity(activity2);
EXPECT_EQ(2, activity_manager->num_activities());
- activity1.reset();
+ Activity::Delete(activity1);
EXPECT_EQ(1, activity_manager->num_activities());
// Deleting the activity's window should delete the activity itself.
« no previous file with comments | « athena/activity/activity_manager_impl.cc ('k') | athena/activity/activity_view_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698