athena/activity/activity.cc - Issue 536013002: Decoupling visibility states from webcontent, adding visibility management in ResourceManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/activity/activity.cc

Issue 536013002: Decoupling visibility states from webcontent, adding visibility management in ResourceManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: athena/activity/activity.cc

diff --git a/athena/activity/activity.cc b/athena/activity/activity.cc

index 6a33f02cb33be1877bb43b4e20875f909ae38c8c..1f23837a7db4b2c72f129c6e43f1b756e9920ab9 100644

--- a/athena/activity/activity.cc

+++ b/athena/activity/activity.cc

@@ -8,8 +8,10 @@

namespace athena {

-Activity::~Activity() {

- ActivityManager::Get()->RemoveActivity(this);

oshima 2014/09/04 22:11:01 optional: maybe we should DCHECK to make sure that

Mr4D (OOO till 08-26) 2014/09/04 22:36:52 Ack. There was no need for an ActivityManager::IsA

+// static

+void Activity::Delete(Activity* activity) {

+ ActivityManager::Get()->RemoveActivity(activity);

+ delete activity;

}

} // namespace athena

« no previous file with comments | « no previous file | athena/activity/activity_manager_impl.cc » ('j') | no next file with comments »