Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2719)

Unified Diff: athena/activity/activity_view_manager_impl.cc

Issue 536013002: Decoupling visibility states from webcontent, adding visibility management in ResourceManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a few more unittests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: athena/activity/activity_view_manager_impl.cc
diff --git a/athena/activity/activity_view_manager_impl.cc b/athena/activity/activity_view_manager_impl.cc
index 3dc8c7cf5b1f71b17a7ba03d7801203ac8246f68..fd8f3da8040dc3422a6e915e5f1da928c84c4b4c 100644
--- a/athena/activity/activity_view_manager_impl.cc
+++ b/athena/activity/activity_view_manager_impl.cc
@@ -29,7 +29,6 @@ views::Widget* CreateWidget(Activity* activity) {
params.delegate = new ActivityWidgetDelegate(view_model);
params.activatable = views::Widget::InitParams::ACTIVATABLE_YES;
widget->Init(params);
- activity->GetActivityViewModel()->Init();
return widget;
}
@@ -57,6 +56,9 @@ class ActivityViewManagerImpl : public ActivityViewManager,
container->UpdateWindowTitle();
container->Show();
container->Activate();
+ // Call the Activity model to initialize itself (and maybe re-order
+ // the activity against others).
+ activity->GetActivityViewModel()->Init();
}
virtual void RemoveActivity(Activity* activity) OVERRIDE {
@@ -81,7 +83,7 @@ class ActivityViewManagerImpl : public ActivityViewManager,
iter != activity_widgets_.end();
++iter) {
if (iter->second == widget) {
- delete iter->first;
+ Activity::CloseActivity(iter->first);
break;
}
}

Powered by Google App Engine
This is Rietveld 408576698