athena/activity/activity_manager_impl.cc - Issue 536013002: Decoupling visibility states from webcontent, adding visibility management in ResourceManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/activity/activity_manager_impl.cc

Issue 536013002: Decoupling visibility states from webcontent, adding visibility management in ResourceManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a few more unittests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: athena/activity/activity_manager_impl.cc

diff --git a/athena/activity/activity_manager_impl.cc b/athena/activity/activity_manager_impl.cc

index c1e1faa6afa87a49dbdedf2a1323a7ed2688ee2c..35ca13777060f8f2ca422655908ec411dafed990 100644

--- a/athena/activity/activity_manager_impl.cc

+++ b/athena/activity/activity_manager_impl.cc

@@ -27,7 +27,7 @@ ActivityManagerImpl::ActivityManagerImpl() {

ActivityManagerImpl::~ActivityManagerImpl() {

while (!activities_.empty())

- delete activities_.front();

+ Activity::CloseActivity(activities_.front());

CHECK_EQ(this, instance);

instance = NULL;

« athena/activity/activity.cc ('K') | « athena/activity/activity.cc ('k') | athena/activity/activity_manager_unittest.cc » ('j') | athena/content/app_activity.cc » ('J')