Decoupling visibility states from webcontent, adding visibility management in ResourceManager

athena/activity/activity.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "athena/activity/public/activity.h"
 
 #include "athena/activity/public/activity_manager.h"
 
 namespace athena {
 
-Activity::~Activity() {
-  ActivityManager::Get()->RemoveActivity(this);
+// static
+void Activity::CloseActivity(Activity* activity) {
+  ActivityManager::Get()->RemoveActivity(activity);
+  delete activity;

[oshima, 2014/09/04 16:39:23]

Maybe we should just have

ActivityManager::DeleteActivity instead ?

And just out of my curiosity, what kind of issue you had?
(I can guess, but want to know exact issue/crash you had)

[Mr4D (OOO till 08-26), 2014/09/04 19:10:57]

During destruction a pure virtual call occured inside
ResourceManagerImpl::OnActivityEnding while accessing the Activity to remove a
window observer. This got called by the ActivityManager as part of the
unregistering at which time the object is apparently already halfway gone.

Renamed to Activity::Delete as discussed.

 }
 
 }  // namespace athena