Disable screen rotation when splitview is engaged and only allow splitview in landscape.

Disable screen rotation when splitview is engaged and only allow splitview in landscape.

BUG=408962
TEST=SplitSplitViewControllerTest.LandscapeOnly

Committed: https://crrev.com/da089db03cecf464d35e3ffef855b3d328f27b7b
Cr-Commit-Position: refs/heads/master@{#293180}

[flackr, 2014-09-03 15:27:02]

flackr@chromium.org changed reviewers:
+ mfomitchev@chromium.org

[flackr, 2014-09-03 15:27:03]

Hey, can you take a look? This prevents entering splitview while in portrait
orientation and locks the rotation when in splitview.

[mfomitchev, 2014-09-03 15:34:00]

https://codereview.chromium.org/535973002/diff/1/athena/wm/split_view_control...
File athena/wm/split_view_controller.cc (right):

https://codereview.chromium.org/535973002/diff/1/athena/wm/split_view_control...
athena/wm/split_view_controller.cc:160:
ScreenManager::Get()->SetRotationLocked(state_ != INACTIVE);
Perhaps we should create a SetState() method and lock/unlock rotation there.
This way the logic would be centralized and we won't be calling
SetRotationLocked when we don't need to.

[mfomitchev, 2014-09-03 15:43:41]

https://codereview.chromium.org/535973002/diff/1/athena/wm/split_view_control...
File athena/wm/split_view_controller_unittest.cc (right):

https://codereview.chromium.org/535973002/diff/1/athena/wm/split_view_control...
athena/wm/split_view_controller_unittest.cc:103:
ASSERT_TRUE(controller->CanScroll());
Perhaps finish the test by rotating it back and confirming you CanScroll()
returns true again.

[flackr, 2014-09-03 16:42:13]

Also created a friend test fixture for the split view tests since CanScroll is
private.

https://codereview.chromium.org/535973002/diff/1/athena/wm/split_view_control...
File athena/wm/split_view_controller.cc (right):

https://codereview.chromium.org/535973002/diff/1/athena/wm/split_view_control...
athena/wm/split_view_controller.cc:160:
ScreenManager::Get()->SetRotationLocked(state_ != INACTIVE);
On 2014/09/03 15:33:59, mfomitchev wrote:
> Perhaps we should create a SetState() method and lock/unlock rotation there.
> This way the logic would be centralized and we won't be calling
> SetRotationLocked when we don't need to.

Done.

https://codereview.chromium.org/535973002/diff/1/athena/wm/split_view_control...
File athena/wm/split_view_controller_unittest.cc (right):

https://codereview.chromium.org/535973002/diff/1/athena/wm/split_view_control...
athena/wm/split_view_controller_unittest.cc:103:
ASSERT_TRUE(controller->CanScroll());
On 2014/09/03 15:43:40, mfomitchev wrote:
> Perhaps finish the test by rotating it back and confirming you CanScroll()
> returns true again.

Done.

[mfomitchev, 2014-09-03 16:44:20]

LGTM

[flackr, 2014-09-03 16:45:05]

flackr@chromium.org changed reviewers:
+ oshima@chromium.org

[flackr, 2014-09-03 16:45:06]

+oshima, PTAL, thanks.

[oshima, 2014-09-03 16:59:40]

lgtm with nits

https://codereview.chromium.org/535973002/diff/20001/athena/wm/split_view_con...
File athena/wm/split_view_controller_unittest.cc (right):

https://codereview.chromium.org/535973002/diff/20001/athena/wm/split_view_con...
athena/wm/split_view_controller_unittest.cc:23: 
nit // test::AthenaTestBase:

https://codereview.chromium.org/535973002/diff/20001/athena/wm/split_view_con...
athena/wm/split_view_controller_unittest.cc:34: bool IsSplitViewAllowed() {
nit: const

[flackr, 2014-09-03 17:36:00]

https://codereview.chromium.org/535973002/diff/20001/athena/wm/split_view_con...
File athena/wm/split_view_controller_unittest.cc (right):

https://codereview.chromium.org/535973002/diff/20001/athena/wm/split_view_con...
athena/wm/split_view_controller_unittest.cc:23: 
On 2014/09/03 16:59:40, oshima wrote:
> nit // test::AthenaTestBase:

Done.

https://codereview.chromium.org/535973002/diff/20001/athena/wm/split_view_con...
athena/wm/split_view_controller_unittest.cc:34: bool IsSplitViewAllowed() {
On 2014/09/03 16:59:40, oshima wrote:
> nit: const

Done.

[flackr, 2014-09-03 17:36:24]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2014-09-03 17:38:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/flackr@chromium.org/535973002/40001

[commit-bot: I haz the power, 2014-09-03 18:56:09]

Committed patchset #3 (id:40001) as 3e4f3686c43af1b328703ad1d8732c8801d67123

[commit-bot: I haz the power, 2014-09-10 03:27:11]

Patchset 3 (id:??) landed as
https://crrev.com/da089db03cecf464d35e3ffef855b3d328f27b7b
Cr-Commit-Position: refs/heads/master@{#293180}