Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: LayoutTests/fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width.html

Issue 535913002: Add scrollbar logical width while computing intrinsic logical width (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix typo + Remove Scrollbar calculation from testcase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width.html
diff --git a/LayoutTests/fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width.html b/LayoutTests/fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width.html
new file mode 100644
index 0000000000000000000000000000000000000000..47fac80ec9aaaa7c0dbd2ece4171de055107378d
--- /dev/null
+++ b/LayoutTests/fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width.html
@@ -0,0 +1,28 @@
+<!DOCTYPE html>
+<html>
+<link href="resources/grid.css" rel="stylesheet">
+<style>
+.grid {
+ position:absolute;
+ overflow:scroll;
+}
+.gridItem {
+ width: 100px;
+ height: 100px;
+ background:green;
+}
+</style>
+<script src="../../resources/check-layout.js"></script>
+<body onload="checkLayout('.grid')">
+
+Test that scrollbar width is added to the width of the grid container.
+<div class='grid' style='top: 100px' data-expected-width='115'>
Julien - ping for review 2014/09/10 16:06:54 I don't think we need the position: absolute and t
Sunil Ratnu 2014/09/11 10:59:44 I think we need it because when I tried testing af
Julien - ping for review 2014/11/19 23:28:40 You don't *need* position per se. What you want is
+ <span class='gridItem'></span>
+</div>
+
+<div class='grid' style='top: 100px; left: 150px; overflow-y: hidden' data-expected-width='100'>
+ <span class='gridItem'></span>
+</div>
+
+</body>
+</html>

Powered by Google App Engine
This is Rietveld 408576698