Source/core/rendering/RenderGrid.cpp - Issue 535913002: Add scrollbar logical width while computing intrinsic logical width

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderGrid.cpp

Issue 535913002: Add scrollbar logical width while computing intrinsic logical width (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use width: fit-content in test case Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width.html ('K') | « Source/core/rendering/RenderFlexibleBox.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderGrid.cpp

diff --git a/Source/core/rendering/RenderGrid.cpp b/Source/core/rendering/RenderGrid.cpp

index e49533146ca89526526759855ff07d6ae2468029..a5e68d1c693645e91a8c2cf4b2f032242dddd11a 100644

--- a/Source/core/rendering/RenderGrid.cpp

+++ b/Source/core/rendering/RenderGrid.cpp

@@ -388,7 +388,9 @@ void RenderGrid::computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, Layo

minLogicalWidth += minTrackBreadth;

maxLogicalWidth += maxTrackBreadth;

- // FIXME: This should add in the scrollbarWidth (e.g. see RenderFlexibleBox).

+ LayoutUnit scrollbarWidth = intrinsicScrollbarLogicalWidth();

+ maxLogicalWidth += scrollbarWidth;

+ minLogicalWidth += scrollbarWidth;

}