LayoutTests/fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width.html - Issue 535913002: Add scrollbar logical width while computing intrinsic logical width

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width.html

Issue 535913002: Add scrollbar logical width while computing intrinsic logical width (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding Test case Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width-expected.txt » ('j') | Source/core/rendering/RenderGrid.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <link href="resources/grid.css" rel="stylesheet">

	4 <style>

	5 .grid {

	6 position:absolute;

	7 overflow:scroll;

	8 }

	9 .gridItem {

	10 width: 100px;

	11 height: 100px;

	12 background:green;

	13 }

	14 </style>

	15 <body>

	16 Test that scrollbar width is added to the width of the grid container.

	17 <div class='grid' style='top: 100px'>

	18 <span class='gridItem'></span>

	19 </div>

	20 <div class='grid' style='top: 100px; left: 150px; overflow-y: hidden' data-no-ve rtical-scrollbar>

	21 <span class='gridItem'></span>

	22 </div>

	23

	24 <script src="../../resources/check-layout.js"></script>

	25 <script>

	26 var dummy = document.createElement('h1');

	27 dummy.style.overflow = 'scroll';

	28 document.body.appendChild(dummy);

	29 var scrollbarWidth = dummy.offsetWidth - dummy.clientWidth;

	30 document.body.removeChild(dummy);

	31

	32 Array.prototype.forEach.call(document.querySelectorAll('div'), function(node) {

	33 var width = 100;

	34 if (!node.hasAttribute('data-no-vertical-scrollbar'))

	35 width += scrollbarWidth;

	36 node.setAttribute('data-expected-width', width);

	37 });
	Julien - ping for review 2014/09/09 14:39:40 The scrollbar width is 16px so no need for this lo The scrollbar width is 16px so no need for this logic. Instead, let's just put the appropriate data-expected-width. Sunil Ratnu 2014/09/09 17:28:30 Done. Show quoted text On 2014/09/09 14:39:40, Julien Chaffraix - PST wrote: > The scrollbar width is 16px so no need for this logic. Instead, let's just put > the appropriate data-expected-width. Done.
	38 checkLayout('body');

	39 </script>

	40 </body>

	41 </html>

OLD	NEW