Adds conversion rule for WebAXRoleFigcaption.

Adds conversion rule for WebAXRoleFigcaption.
It is handled as 'IA2_ROLE_CAPTION' for IA2.
The Related CL:
https://codereview.chromium.org/533893004/

BUG=282035
Committed: https://crrev.com/6d3ff1db3ac108434add039a91813fda93f7a027
Cr-Commit-Position: refs/heads/master@{#295488}

[je_julie(Not used), 2014-09-03 10:01:43]

je_julie.kim@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[je_julie(Not used), 2014-09-03 10:02:12]

dmazzoni, PTAL.

[dmazzoni, 2014-09-03 21:23:13]

Could you add a test for this using the DumpAccessibilityTree test suite?

Modify content/browser/accessibility/dump_accessibility_tree_browsertest.cc and
add your test file to content/test/data/accessibility. Use try jobs to confirm
the correct output.

https://codereview.chromium.org/535893002/diff/1/content/renderer/accessibili...
File content/renderer/accessibility/blink_ax_enum_conversion.cc (right):

https://codereview.chromium.org/535893002/diff/1/content/renderer/accessibili...
content/renderer/accessibility/blink_ax_enum_conversion.cc:144: return
ui::AX_ROLE_FIGCAPTION;
nit: fix indentation here

https://codereview.chromium.org/535893002/diff/1/ui/accessibility/platform/ax...
File ui/accessibility/platform/ax_platform_node_mac.mm (right):

https://codereview.chromium.org/535893002/diff/1/ui/accessibility/platform/ax...
ui/accessibility/platform/ax_platform_node_mac.mm:52: {ui::AX_ROLE_FIGCAPTION,
NSAccessibilityStaticTextRole},
I think this should be NSAccessibilityGroupRole. A static text role should only
be used for a leaf-level node, and a <figcaption> might have children.

[je_julie(Not used), 2014-09-04 00:26:05]

On 2014/09/03 21:23:13, dmazzoni wrote:
> Could you add a test for this using the DumpAccessibilityTree test suite?
> 
> Modify content/browser/accessibility/dump_accessibility_tree_browsertest.cc
and
> add your test file to content/test/data/accessibility. Use try jobs to confirm
> the correct output.
> 
>
https://codereview.chromium.org/535893002/diff/1/content/renderer/accessibili...
> File content/renderer/accessibility/blink_ax_enum_conversion.cc (right):
> 
OK, I'll try it.

>
https://codereview.chromium.org/535893002/diff/1/content/renderer/accessibili...
> content/renderer/accessibility/blink_ax_enum_conversion.cc:144: return
> ui::AX_ROLE_FIGCAPTION;
> nit: fix indentation here
> 
I'll update it.
>
https://codereview.chromium.org/535893002/diff/1/ui/accessibility/platform/ax...
> File ui/accessibility/platform/ax_platform_node_mac.mm (right):
> 
>
https://codereview.chromium.org/535893002/diff/1/ui/accessibility/platform/ax...
> ui/accessibility/platform/ax_platform_node_mac.mm:52: {ui::AX_ROLE_FIGCAPTION,
> NSAccessibilityStaticTextRole},
> I think this should be NSAccessibilityGroupRole. A static text role should
only
> be used for a leaf-level node, and a <figcaption> might have children.
Yes, you're right. 
I have one thing which I'd like to check with you.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/AT-APIs/Gecko/Role...
Usually, I refer to firefox working when I assigned role and I found that
document.
That's why I used 'NSAccessibilityStaticTextRole'.
If this mapping table's not fit to figcaption's working, I'll update with
'NSAccessibilityGroupRole'.
Please check.

[dmazzoni, 2014-09-04 15:35:14]

On Wed, Sep 3, 2014 at 5:26 PM, <je_julie.kim@samsung.com> wrote:

> I have one thing which I'd like to check with you.
> https://developer.mozilla.org/en-US/docs/Web/Accessibility/
> AT-APIs/Gecko/Roles/ROLE_CAPTION
> Usually, I refer to firefox working when I assigned role and I found that
> document.
> That's why I used 'NSAccessibilityStaticTextRole'.
> If this mapping table's not fit to figcaption's working, I'll update with
> 'NSAccessibilityGroupRole'.
> Please check.
>

http://www.w3.org/TR/html-aapi/ says NSAccessibilityGroupRole and that's a
more definitive reference.

It's possible Firefox implements it differently. If they make <figcaption>
a leaf node that's not allowed to have any children, then they could give
it a role of static text and that'd work fine. We could consider doing that
in Chrome. But right now the way it's implemented, it will have children -
and as such it's not okay for it to have a static text role.

- Dominic

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[je_julie(Not used), 2014-09-05 17:39:07]

Patchset #2 (id:20001) has been deleted

[je_julie(Not used), 2014-09-05 17:59:16]

Dominic,
I changed role to group for mac and added TC and results from mac and window.

And I have a question about accessibility test on android.
I couldn't get result from android.
I can see other test result like, 
[----------] 9 tests from BrowserAccessibilityManagerTest
[ RUN      ] BrowserAccessibilityManagerTest.TestNoLeaks
[       OK ] BrowserAccessibilityManagerTest.TestNoLeaks (0 ms)
[ RUN      ]
BrowserAccessibilityManagerTest.TestReuseBrowserAccessibilityObjects
[       OK ]
BrowserAccessibilityManagerTest.TestReuseBrowserAccessibilityObjects (0 ms)
[ RUN      ]
BrowserAccessibilityManagerTest.TestReuseBrowserAccessibilityObjects2
[       OK ]
BrowserAccessibilityManagerTest.TestReuseBrowserAccessibilityObjects2 (0 ms)
[ RUN      ] BrowserAccessibilityManagerTest.TestMoveChildUp
[       OK ] BrowserAccessibilityManagerTest.TestMoveChildUp (0 ms)
[ RUN      ] BrowserAccessibilityManagerTest.TestFatalError

I tried to run "build/android/test_runner.py gtest -s content_unittests
--release -vvv" and "build/android/test_runner.py gtest -s content_unittests
--release -vvv -f DumpAccessibilityTree*" and I'm using android SDK on linux.
Did I miss something?
Please take a look.

[je_julie(Not used), 2014-09-10 01:11:53]

Dominic, PTAL.

[dmazzoni, 2014-09-10 05:44:23]

On 2014/09/05 17:59:16, je_julie.kim wrote:
> Dominic,
> I changed role to group for mac and added TC and results from mac and window.
> 
> And I have a question about accessibility test on android.
> I couldn't get result from android.
> I can see other test result like, 
> [----------] 9 tests from BrowserAccessibilityManagerTest
> [ RUN      ] BrowserAccessibilityManagerTest.TestNoLeaks
> [       OK ] BrowserAccessibilityManagerTest.TestNoLeaks (0 ms)
> [ RUN      ]
> BrowserAccessibilityManagerTest.TestReuseBrowserAccessibilityObjects
> [       OK ]
> BrowserAccessibilityManagerTest.TestReuseBrowserAccessibilityObjects (0 ms)
> [ RUN      ]
> BrowserAccessibilityManagerTest.TestReuseBrowserAccessibilityObjects2
> [       OK ]
> BrowserAccessibilityManagerTest.TestReuseBrowserAccessibilityObjects2 (0 ms)
> [ RUN      ] BrowserAccessibilityManagerTest.TestMoveChildUp
> [       OK ] BrowserAccessibilityManagerTest.TestMoveChildUp (0 ms)
> [ RUN      ] BrowserAccessibilityManagerTest.TestFatalError
> 
> I tried to run "build/android/test_runner.py gtest -s content_unittests
> --release -vvv" and "build/android/test_runner.py gtest -s content_unittests
> --release -vvv -f DumpAccessibilityTree*" and I'm using android SDK on linux.

I think you want content_browsertests?

> Did I miss something?
> Please take a look.

[dmazzoni, 2014-09-10 05:47:12]

lgtm

Looks good. Don't worry about the Android test since it won't have anything
interesting in it anyway. Just put this in the file and it will pass:

#<skip - need to generate expectation>

I'll update a bunch of Android expectations later.

[je_julie(Not used), 2014-09-10 10:06:15]

Dominic,
Thank you for review.

> Looks good. Don't worry about the Android test since it won't have anything
> interesting in it anyway. Just put this in the file and it will pass:
> 
> #<skip - need to generate expectation>

Do you mean 'src/build/android/pylib/gtest/filter/content_browsertests_disabled'
file?
I saw there are TC lists skipped.
If so, I'll update patch with that file.

[je_julie(Not used), 2014-09-13 00:41:32]

Dominic,
I added figcaption TC to content_browsertests_disabled.
PTAL.

[je_julie(Not used), 2014-09-13 14:25:37]

On 2014/09/13 00:41:32, je_julie.kim wrote:
> Dominic,
> I added figcaption TC to content_browsertests_disabled.
> PTAL.

Now, I see what you mean.
I added 'figcaption-expected-android.txt' with "#<skip - need to generate
expectation>".
PTAL.

[dmazzoni, 2014-09-18 14:51:07]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-09-18 14:52:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/535893002/80001

[commit-bot: I haz the power, 2014-09-18 17:19:33]

Committed patchset #4 (id:80001) as 2d329665b8a0a04b1e98b65e22296f3c05e1e4c9

[commit-bot: I haz the power, 2014-09-18 17:20:09]

Patchset 4 (id:??) landed as
https://crrev.com/6d3ff1db3ac108434add039a91813fda93f7a027
Cr-Commit-Position: refs/heads/master@{#295488}