Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 535843002: Web Animations: Add a name to AnimationNode and trace running players (Closed)

Created:
6 years, 3 months ago by dstockwell
Modified:
6 years, 3 months ago
Reviewers:
shane.stephens, shans
CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), nduca, rjwright, shans, Steve Block, Timothy Loh
Project:
blink
Visibility:
Public.

Description

Web Animations: Add a name to AnimationNode and trace running players For CSS Animations the name is prefilled with the animation-name. For Transitions the name is the transitioning property. BUG=351446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181724

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Use setFinished in uncancel. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -15 lines) Patch
M Source/core/animation/AnimationNode.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationPlayer.h View 1 2 2 chunks +2 lines, -10 lines 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 1 2 8 chunks +36 lines, -5 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dstockwell
6 years, 3 months ago (2014-09-03 08:22:07 UTC) #2
shane.stephens
lgtm
6 years, 3 months ago (2014-09-10 09:45:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/535843002/40001
6 years, 3 months ago (2014-09-10 09:45:54 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-10 09:45:56 UTC) #8
shans
lgtm
6 years, 3 months ago (2014-09-10 09:47:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/535843002/40001
6 years, 3 months ago (2014-09-10 09:48:03 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 10:35:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 181724

Powered by Google App Engine
This is Rietveld 408576698