Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 535823002: Don't crash when an image fails to decode. (Closed)

Created:
6 years, 3 months ago by ckulakowski
Modified:
6 years, 3 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Don't crash when an image fails to decode. The code that extracts the image for the default frame from an animated bitmap should check that the image data is actually available. It is possible for decoding to fail for invalid frames, Blink should not crash when this happens. BUG=408026 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182496

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
A LayoutTests/fast/images/resources/wrong-frame-dimensions.ico View Binary file 0 comments Download
M Source/platform/graphics/BitmapImage.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/BitmapImageTest.cpp View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ckulakowski
6 years, 3 months ago (2014-09-05 08:28:26 UTC) #2
Justin Novosad
On 2014/09/05 08:28:26, ckulakowski wrote: lgtm
6 years, 3 months ago (2014-09-05 15:15:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/535823002/1
6 years, 3 months ago (2014-09-22 06:28:13 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/platform/graphics/BitmapImage.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 3 months ago (2014-09-22 06:28:21 UTC) #7
ckulakowski
6 years, 3 months ago (2014-09-23 12:21:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/535823002/20001
6 years, 3 months ago (2014-09-23 12:28:06 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 13:29:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182496

Powered by Google App Engine
This is Rietveld 408576698