Update smoothness.py to restore summarized results for some metrics.

Update smoothness.py to restore summarized results for metrics that don't care if some values are None:

mean_input_event_latency, input_event_latency_discrepancy, mean_scroll_update_latency, scroll_update_latency_discrepancy, first_gesture_scroll_update_latency

BUG=410018
Committed: https://crrev.com/5c1e66643d7b5b14d457837ee733be99b553639e
Cr-Commit-Position: refs/heads/master@{#293380}

[ariblue, 2014-09-03 02:24:06]

ariblue@google.com changed reviewers:
+ dtu@chromium.org, miletus@chromium.org, qyearsley@chromium.org

[Yufeng Shen (Slow to review), 2014-09-03 17:44:10]

On 2014/09/03 02:24:07, ariblue wrote:

I am getting the error msg when testing it out locally:

miletus@miletus2:/usr/local/google/clank/src$ tools/perf/run_benchmark
--browser=android-chrome-shell smoothness.key_silk_cases --page-filter="google"
WARNING:root:Cannot set CPU affinity due to stale psutil version: 0.4.1
WARNING:root:Cannot set CPU affinity due to stale psutil version: 0.4.1
WARNING:root:Installing ./out/Release/apks/ChromeShell.apk on device if needed.
[ RUN      ] http://www.google.com/#q=google

Unhandled exception while running http://www.google.com/#q=google

Traceback (most recent call last):
  _RunPage at tools/telemetry/telemetry/page/page_runner.py:528
    test.RunPage(page, page_state.tab, results)
  RunPage at tools/telemetry/telemetry/page/page_test.py:309
    self.ValidateAndMeasurePage(page, tab, results)
  ValidateAndMeasurePage at tools/perf/measurements/smoothness.py:40
    self._smoothness_controller.AddResults(tab, results)
  AddResults at tools/perf/measurements/smoothness_controller.py:110
    self._timeline_model, renderer_thread, smooth_records, results)
  AddResults at tools/telemetry/telemetry/web_perf/metrics/smoothness.py:53
    self._PopulateResultsFromStats(results, stats)
  _PopulateResultsFromStats at
tools/telemetry/telemetry/web_perf/metrics/smoothness.py:69
    results.AddValue(v)
  AddValue at tools/telemetry/telemetry/results/page_test_results.py:148
    self._ValidateValue(value)
  _ValidateValue at tools/telemetry/telemetry/results/page_test_results.py:159
    assert isinstance(value, value_module.Value)
AssertionError

Locals:
  value : ()

[ariblue, 2014-09-03 18:34:06]

On 2014/09/03 17:44:10, Yufeng Shen wrote:
> On 2014/09/03 02:24:07, ariblue wrote:
> 
> I am getting the error msg when testing it out locally:
> 
> miletus@miletus2:/usr/local/google/clank/src$ tools/perf/run_benchmark
> --browser=android-chrome-shell smoothness.key_silk_cases
--page-filter="google"
> WARNING:root:Cannot set CPU affinity due to stale psutil version: 0.4.1
> WARNING:root:Cannot set CPU affinity due to stale psutil version: 0.4.1
> WARNING:root:Installing ./out/Release/apks/ChromeShell.apk on device if
needed.
> [ RUN      ] http://www.google.com/#q=google
> 
> Unhandled exception while running http://www.google.com/#q=google
> 
> Traceback (most recent call last):
>   _RunPage at tools/telemetry/telemetry/page/page_runner.py:528
>     test.RunPage(page, page_state.tab, results)
>   RunPage at tools/telemetry/telemetry/page/page_test.py:309
>     self.ValidateAndMeasurePage(page, tab, results)
>   ValidateAndMeasurePage at tools/perf/measurements/smoothness.py:40
>     self._smoothness_controller.AddResults(tab, results)
>   AddResults at tools/perf/measurements/smoothness_controller.py:110
>     self._timeline_model, renderer_thread, smooth_records, results)
>   AddResults at tools/telemetry/telemetry/web_perf/metrics/smoothness.py:53
>     self._PopulateResultsFromStats(results, stats)
>   _PopulateResultsFromStats at
> tools/telemetry/telemetry/web_perf/metrics/smoothness.py:69
>     results.AddValue(v)
>   AddValue at tools/telemetry/telemetry/results/page_test_results.py:148
>     self._ValidateValue(value)
>   _ValidateValue at tools/telemetry/telemetry/results/page_test_results.py:159
>     assert isinstance(value, value_module.Value)
> AssertionError
> 
> Locals:
>   value : ()

Hey, sorry about that. I was overzealous in adding the fix for the
first_gesture_scroll_update_latency also, without testing that part of the
change. I've updated the fix to handle that case correctly, as well.

[Yufeng Shen (Slow to review), 2014-09-03 21:21:47]

On 2014/09/03 18:34:06, ariblue wrote:
> On 2014/09/03 17:44:10, Yufeng Shen wrote:
> > On 2014/09/03 02:24:07, ariblue wrote:
> > 
> > I am getting the error msg when testing it out locally:
> > 
> > miletus@miletus2:/usr/local/google/clank/src$ tools/perf/run_benchmark
> > --browser=android-chrome-shell smoothness.key_silk_cases
> --page-filter="google"
> > WARNING:root:Cannot set CPU affinity due to stale psutil version: 0.4.1
> > WARNING:root:Cannot set CPU affinity due to stale psutil version: 0.4.1
> > WARNING:root:Installing ./out/Release/apks/ChromeShell.apk on device if
> needed.
> > [ RUN      ] http://www.google.com/#q=google
> > 
> > Unhandled exception while running http://www.google.com/#q=google
> > 
> > Traceback (most recent call last):
> >   _RunPage at tools/telemetry/telemetry/page/page_runner.py:528
> >     test.RunPage(page, page_state.tab, results)
> >   RunPage at tools/telemetry/telemetry/page/page_test.py:309
> >     self.ValidateAndMeasurePage(page, tab, results)
> >   ValidateAndMeasurePage at tools/perf/measurements/smoothness.py:40
> >     self._smoothness_controller.AddResults(tab, results)
> >   AddResults at tools/perf/measurements/smoothness_controller.py:110
> >     self._timeline_model, renderer_thread, smooth_records, results)
> >   AddResults at tools/telemetry/telemetry/web_perf/metrics/smoothness.py:53
> >     self._PopulateResultsFromStats(results, stats)
> >   _PopulateResultsFromStats at
> > tools/telemetry/telemetry/web_perf/metrics/smoothness.py:69
> >     results.AddValue(v)
> >   AddValue at tools/telemetry/telemetry/results/page_test_results.py:148
> >     self._ValidateValue(value)
> >   _ValidateValue at
tools/telemetry/telemetry/results/page_test_results.py:159
> >     assert isinstance(value, value_module.Value)
> > AssertionError
> > 
> > Locals:
> >   value : ()
> 
> Hey, sorry about that. I was overzealous in adding the fix for the
> first_gesture_scroll_update_latency also, without testing that part of the
> change. I've updated the fix to handle that case correctly, as well.

lgtm

[ariblue, 2014-09-03 21:42:17]

The CQ bit was checked by ariblue@google.com

[commit-bot: I haz the power, 2014-09-03 23:24:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ariblue@google.com/535783002/20001

[commit-bot: I haz the power, 2014-09-04 01:32:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 01:32:05]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ariblue, 2014-09-04 17:28:35]

ariblue@google.com changed reviewers:
+ nednguyen@google.com

[nednguyen, 2014-09-04 23:20:24]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2014-09-04 23:21:58]

lgtm

This is just a bandage patch. The real fix will require more thought on
summarizing policy.

[commit-bot: I haz the power, 2014-09-04 23:23:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ariblue@google.com/535783002/20001

[commit-bot: I haz the power, 2014-09-05 00:26:55]

Committed patchset #2 (id:20001) as 06a6cc473746567505031ad16b2039a8a3bc7478

[commit-bot: I haz the power, 2014-09-10 03:34:14]

Patchset 2 (id:??) landed as
https://crrev.com/5c1e66643d7b5b14d457837ee733be99b553639e
Cr-Commit-Position: refs/heads/master@{#293380}