Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 535773002: Android: Remove more browser extensions code, including some that snuck back in. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, asanka, skanuj+watch_chromium.org, posciak+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, markusheintz_, extensions-reviews_chromium.org, melevin+watch_chromium.org, benjhayden+dwatch_chromium.org, dominich, chromium-apps-reviews_chromium.org, feature-media-reviews_chromium.org, jfweitz+watch_chromium.org, Jered, tfarina, donnd+watch_chromium.org, mcasas+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Android: Remove more browser extensions code, including some that snuck back in. Committed: https://crrev.com/428c2caf55527dd1bf8f0e69dfd6061a7ad12be4 Cr-Commit-Position: refs/heads/master@{#293657}

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : fix android #

Patch Set 4 : fix android part 2 #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -84 lines) Patch
M chrome/browser/content_settings/cookie_settings_unittest.cc View 1 2 3 4 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 2 3 4 4 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_unittest.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/download/download_crx_util_android.cc View 1 chunk +1 line, -29 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor.cc View 8 chunks +14 lines, -5 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 2 3 4 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_utils.cc View 5 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_instant_controller.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/media_utils.cc View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 2 chunks +2 lines, -17 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 3 chunks +17 lines, -0 lines 0 comments Download
M components/renderer_context_menu/context_menu_content_type.cc View 4 chunks +9 lines, -2 lines 0 comments Download
M components/renderer_context_menu/render_view_context_menu_base.cc View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 35 (17 generated)
Lei Zhang
PTAL review components/renderer_context_menu, and if possible chrome/
6 years, 3 months ago (2014-09-03 02:18:11 UTC) #3
lazyboy
lgtm I'm not familiar /w the code other than context_menu* ones, those LGTM. I've looked ...
6 years, 3 months ago (2014-09-03 15:49:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/535773002/20001
6 years, 3 months ago (2014-09-03 21:35:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/535773002/40001
6 years, 3 months ago (2014-09-04 00:06:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1883) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/4991)
6 years, 3 months ago (2014-09-04 02:03:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/535773002/40001
6 years, 3 months ago (2014-09-04 02:20:02 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1942)
6 years, 3 months ago (2014-09-04 03:04:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/535773002/40001
6 years, 3 months ago (2014-09-04 06:08:16 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/5103)
6 years, 3 months ago (2014-09-04 08:01:42 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/535773002/80001
6 years, 3 months ago (2014-09-05 14:53:52 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/52174)
6 years, 3 months ago (2014-09-05 15:00:30 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/535773002/100001
6 years, 3 months ago (2014-09-05 18:43:39 UTC) #25
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 00:45:05 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/535773002/100001
6 years, 3 months ago (2014-09-06 03:24:30 UTC) #29
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 09:26:57 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/535773002/100001
6 years, 3 months ago (2014-09-07 06:17:17 UTC) #33
commit-bot: I haz the power
Committed patchset #5 (id:100001) as f4523d0870ccad34d55deabebeb924c886f08303
6 years, 3 months ago (2014-09-07 06:19:43 UTC) #34
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:44:08 UTC) #35
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/428c2caf55527dd1bf8f0e69dfd6061a7ad12be4
Cr-Commit-Position: refs/heads/master@{#293657}

Powered by Google App Engine
This is Rietveld 408576698