Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: content/child/service_worker/service_worker_dispatcher.cc

Issue 535753002: ServiceWorker: Implement navigator.serviceWorker.getRegistration [2/3] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/service_worker_dispatcher.cc
diff --git a/content/child/service_worker/service_worker_dispatcher.cc b/content/child/service_worker/service_worker_dispatcher.cc
index df616df99896a64a39dfa496acec0a2ad41e747f..4ebb9edbb32c82f87153e4f4c71ba970d9b61b4c 100644
--- a/content/child/service_worker/service_worker_dispatcher.cc
+++ b/content/child/service_worker/service_worker_dispatcher.cc
@@ -61,10 +61,14 @@ void ServiceWorkerDispatcher::OnMessageReceived(const IPC::Message& msg) {
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_ServiceWorkerRegistered, OnRegistered)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_ServiceWorkerUnregistered,
OnUnregistered)
+ IPC_MESSAGE_HANDLER(ServiceWorkerMsg_DidGetRegistration,
+ OnDidGetRegistration)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_ServiceWorkerRegistrationError,
OnRegistrationError)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_ServiceWorkerUnregistrationError,
OnUnregistrationError)
+ IPC_MESSAGE_HANDLER(ServiceWorkerMsg_ServiceWorkerGetRegistrationError,
+ OnGetRegistrationError)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_ServiceWorkerStateChanged,
OnServiceWorkerStateChanged)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_SetVersionAttributes,
@@ -135,6 +139,30 @@ void ServiceWorkerDispatcher::UnregisterServiceWorker(
CurrentWorkerId(), request_id, provider_id, pattern));
}
+void ServiceWorkerDispatcher::GetRegistration(
+ int provider_id,
+ const GURL& document_url,
+ WebServiceWorkerRegistrationCallbacks* callbacks) {
+ DCHECK(callbacks);
+
+ if (document_url.possibly_invalid_spec().size() > GetMaxURLChars()) {
+ scoped_ptr<WebServiceWorkerRegistrationCallbacks>
+ owned_callbacks(callbacks);
+ scoped_ptr<WebServiceWorkerError> error(new WebServiceWorkerError(
+ WebServiceWorkerError::ErrorTypeSecurity, "URL too long"));
+ callbacks->onError(error.release());
+ return;
+ }
+
+ int request_id = pending_get_registration_callbacks_.Add(callbacks);
+ TRACE_EVENT_ASYNC_BEGIN1("ServiceWorker",
+ "ServiceWorkerDispatcher::GetRegistration",
+ request_id,
+ "Document URL", document_url.spec());
+ thread_safe_sender_->Send(new ServiceWorkerHostMsg_GetRegistration(
+ CurrentWorkerId(), request_id, provider_id, document_url));
+}
+
void ServiceWorkerDispatcher::AddProviderContext(
ServiceWorkerProviderContext* provider_context) {
DCHECK(provider_context);
@@ -303,25 +331,7 @@ void ServiceWorkerDispatcher::OnRegistered(
if (!callbacks)
return;
- WebServiceWorkerRegistrationImpl* registration =
- FindServiceWorkerRegistration(info, true);
- if (!registration) {
- registration = CreateServiceWorkerRegistration(info, true);
- registration->SetInstalling(GetServiceWorker(attrs.installing, true));
- registration->SetWaiting(GetServiceWorker(attrs.waiting, true));
- registration->SetActive(GetServiceWorker(attrs.active, true));
- } else {
- // |registration| must already have version attributes, so adopt and destroy
- // handle refs for them.
- ServiceWorkerHandleReference::Adopt(
- attrs.installing, thread_safe_sender_.get());
- ServiceWorkerHandleReference::Adopt(
- attrs.waiting, thread_safe_sender_.get());
- ServiceWorkerHandleReference::Adopt(
- attrs.active, thread_safe_sender_.get());
- }
-
- callbacks->onSuccess(registration);
+ callbacks->onSuccess(FindOrCreateRegistration(info, attrs));
pending_registration_callbacks_.Remove(request_id);
TRACE_EVENT_ASYNC_END0("ServiceWorker",
"ServiceWorkerDispatcher::RegisterServiceWorker",
@@ -348,6 +358,33 @@ void ServiceWorkerDispatcher::OnUnregistered(int thread_id,
request_id);
}
+void ServiceWorkerDispatcher::OnDidGetRegistration(
+ int thread_id,
+ int request_id,
+ const ServiceWorkerRegistrationObjectInfo& info,
+ const ServiceWorkerVersionAttributes& attrs) {
+ WebServiceWorkerRegistrationCallbacks* callbacks =
+ pending_get_registration_callbacks_.Lookup(request_id);
+ TRACE_EVENT_ASYNC_STEP_INTO0(
+ "ServiceWorker",
+ "ServiceWorkerDispatcher::GetRegistration",
+ request_id,
+ "OnDidGetRegistration");
+ DCHECK(callbacks);
+ if (!callbacks)
+ return;
+
+ WebServiceWorkerRegistrationImpl* registration = NULL;
+ if (info.handle_id != kInvalidServiceWorkerHandleId)
+ registration = FindOrCreateRegistration(info, attrs);
+
+ callbacks->onSuccess(registration);
+ pending_get_registration_callbacks_.Remove(request_id);
+ TRACE_EVENT_ASYNC_END0("ServiceWorker",
+ "ServiceWorkerDispatcher::GetRegistration",
+ request_id);
+}
+
void ServiceWorkerDispatcher::OnRegistrationError(
int thread_id,
int request_id,
@@ -397,6 +434,31 @@ void ServiceWorkerDispatcher::OnUnregistrationError(
request_id);
}
+void ServiceWorkerDispatcher::OnGetRegistrationError(
+ int thread_id,
+ int request_id,
+ WebServiceWorkerError::ErrorType error_type,
+ const base::string16& message) {
+ TRACE_EVENT_ASYNC_STEP_INTO0(
+ "ServiceWorker",
+ "ServiceWorkerDispatcher::GetRegistration",
+ request_id,
+ "OnGetRegistrationError");
+ WebServiceWorkerGetRegistrationCallbacks* callbacks =
+ pending_get_registration_callbacks_.Lookup(request_id);
+ DCHECK(callbacks);
+ if (!callbacks)
+ return;
+
+ scoped_ptr<WebServiceWorkerError> error(
+ new WebServiceWorkerError(error_type, message));
+ callbacks->onError(error.release());
+ pending_get_registration_callbacks_.Remove(request_id);
+ TRACE_EVENT_ASYNC_END0("ServiceWorker",
+ "ServiceWorkerDispatcher::GetRegistration",
+ request_id);
+}
+
void ServiceWorkerDispatcher::OnServiceWorkerStateChanged(
int thread_id,
int handle_id,
@@ -650,4 +712,28 @@ void ServiceWorkerDispatcher::RemoveServiceWorkerRegistration(
registrations_.erase(registration_handle_id);
}
+WebServiceWorkerRegistrationImpl*
+ServiceWorkerDispatcher::FindOrCreateRegistration(
+ const ServiceWorkerRegistrationObjectInfo& info,
+ const ServiceWorkerVersionAttributes& attrs) {
+ WebServiceWorkerRegistrationImpl* registration =
+ FindServiceWorkerRegistration(info, true);
+ if (!registration) {
+ registration = CreateServiceWorkerRegistration(info, true);
+ registration->SetInstalling(GetServiceWorker(attrs.installing, true));
+ registration->SetWaiting(GetServiceWorker(attrs.waiting, true));
+ registration->SetActive(GetServiceWorker(attrs.active, true));
+ } else {
+ // |registration| must already have version attributes, so adopt and destroy
+ // handle refs for them.
+ ServiceWorkerHandleReference::Adopt(
+ attrs.installing, thread_safe_sender_.get());
+ ServiceWorkerHandleReference::Adopt(
+ attrs.waiting, thread_safe_sender_.get());
+ ServiceWorkerHandleReference::Adopt(
+ attrs.active, thread_safe_sender_.get());
+ }
+ return registration;
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698