Issue 535733004: Minor-key-ify remaining code stubs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 535733004: Minor-key-ify remaining code stubs. (Closed)

Created:
6 years, 3 months ago by Yang

Modified:
6 years, 3 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+280 lines, -385 lines)			Patch
M	src/arm/code-stubs-arm.h	View	8 chunks	+58 lines, -43 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	12 chunks	+22 lines, -129 lines	0 comments	Download
M	src/arm64/code-stubs-arm64.h	View	7 chunks	+42 lines, -36 lines	1 comment	Download
M	src/arm64/code-stubs-arm64.cc	View	10 chunks	+26 lines, -37 lines	0 comments	Download
M	src/code-stubs.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/code-stubs-ia32.h	View	6 chunks	+50 lines, -37 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	11 chunks	+17 lines, -31 lines	0 comments	Download
M	src/x64/code-stubs-x64.h	View	5 chunks	+50 lines, -43 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	11 chunks	+14 lines, -28 lines	0 comments	Download

Total messages: 3 (0 generated)

mvstanton

I think there is one error on arm64. If you fix that, then: LGTM. https://codereview.chromium.org/535733004/diff/1/src/arm64/code-stubs-arm64.h ...

6 years, 3 months ago (2014-09-03 11:00:48 UTC) #2

Yang

6 years, 3 months ago (2014-09-03 11:42:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23643 (presubmit successful).