Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Issue 535723002: ipc/ fixups for scoped_refptr operator T* removal. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ipc/ fixups for scoped_refptr operator T* removal. BUG=110610 Committed: https://crrev.com/ff04843f8e1764f37fd0133a61f2727ab1b7960e Cr-Commit-Position: refs/heads/master@{#293170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M ipc/ipc_sync_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_test_base.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ipc/ipc_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Just some small fixups for cases that had to be handled manually/added after the first ...
6 years, 3 months ago (2014-09-02 23:51:44 UTC) #2
Tom Sepez
lgtm
6 years, 3 months ago (2014-09-03 16:42:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/535723002/1
6 years, 3 months ago (2014-09-03 16:46:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7ce823eaee75b44792e78433023a3249dd2ea1fa
6 years, 3 months ago (2014-09-03 18:03:01 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:26:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff04843f8e1764f37fd0133a61f2727ab1b7960e
Cr-Commit-Position: refs/heads/master@{#293170}

Powered by Google App Engine
This is Rietveld 408576698