Source/core/html/HTMLMediaElement.h - Issue 535703002: HTMLMediaElement shouldn't call currentTime() when we HAVE_NOTHING.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 535703002: HTMLMediaElement shouldn't call currentTime() when we HAVE_NOTHING. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fixes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLMediaElement.h

diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h

index d3094784e3570e14964e54449d6bf4b6282639bc..faff193e8d55526b045b62f17d1b5a6c207fe3cd 100644

--- a/Source/core/html/HTMLMediaElement.h

+++ b/Source/core/html/HTMLMediaElement.h

@@ -540,9 +540,9 @@ private:

RefPtrWillBeMember<HTMLMediaSource> m_mediaSource;

+ // Cached time value. Only valid when ready state is HAVE_METADATA or

+ // higher, otherwise the current time is assumed to be zero.

mutable double m_cachedTime;

- mutable double m_cachedTimeWallClockUpdateTime;

- mutable double m_minimumWallClockTimeToCacheMediaTime;

double m_fragmentStartTime;

double m_fragmentEndTime;

« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')