chrome/browser/sync/profile_sync_service_autofill_unittest.cc - Issue 535683002: Fix use-after-free in HDDDTC shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_autofill_unittest.cc

Issue 535683002: Fix use-after-free in HDDDTC shutdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/profile_sync_service_autofill_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc

index 8c7cddf232e7f0df1dfca75c36b9309f4be8c432..10fb76105763e1fc805e9482e0c2fa377e15291c 100644

--- a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc

@@ -362,8 +362,7 @@ ACTION_P(ReturnNewDataTypeManagerWithDebugListener, debug_listener) {

arg1,

arg2,

arg3,

- arg4,

- arg5);

+ arg4);

}

ACTION_P(MakeAutofillProfileSyncComponents, wds) {

@@ -557,7 +556,7 @@ class ProfileSyncServiceAutofillTest

web_data_service_.get(),

data_type_controller);

- EXPECT_CALL(*components, CreateDataTypeManager(_, _, _, _, _, _)).

+ EXPECT_CALL(*components, CreateDataTypeManager(_, _, _, _, _)).

WillOnce(ReturnNewDataTypeManagerWithDebugListener(

syncer::MakeWeakHandle(debug_ptr_factory_.GetWeakPtr())));