chrome/browser/sync/profile_sync_components_factory_impl.h - Issue 535683002: Fix use-after-free in HDDDTC shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_components_factory_impl.h

Issue 535683002: Fix use-after-free in HDDDTC shutdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/profile_sync_components_factory_impl.h

diff --git a/chrome/browser/sync/profile_sync_components_factory_impl.h b/chrome/browser/sync/profile_sync_components_factory_impl.h

index 86048058993b79734e8f2a39ae6daa92ffead518..5ccd6c2635c312a769943583979035b75f70288f 100644

--- a/chrome/browser/sync/profile_sync_components_factory_impl.h

+++ b/chrome/browser/sync/profile_sync_components_factory_impl.h

@@ -50,8 +50,7 @@ class ProfileSyncComponentsFactoryImpl : public ProfileSyncComponentsFactory {

const sync_driver::DataTypeController::TypeMap* controllers,

const sync_driver::DataTypeEncryptionHandler* encryption_handler,

browser_sync::SyncBackendHost* backend,

- sync_driver::DataTypeManagerObserver* observer,

- sync_driver::DataTypeStatusTable* data_type_status_table)

+ sync_driver::DataTypeManagerObserver* observer)

OVERRIDE;

virtual browser_sync::SyncBackendHost* CreateSyncBackendHost(