Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 535673004: Gallery: Fix scrolling by touch in the mosaic view. (Closed)

Created:
6 years, 3 months ago by hirono
Modified:
6 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Gallery: Fix scrolling by touch in the mosaic view. We cannot scroll the mosaic view by touching since crrev.com/283688. The touch event is covered by other elements. pointe-events:none does not help to make it scrollable by touch. BUG=404960 TEST=test scrolling on link Committed: https://crrev.com/0da5098d7e901bef3770f316c44e480e7087803d Cr-Commit-Position: refs/heads/master@{#293281}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -32 lines) Patch
M apps/app_shim/app_shim_host_manager_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M apps/app_shim/chrome_main_app_mode_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M apps/app_shim/unix_domain_socket_acceptor.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M apps/launcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/device_event_router.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/storage/leveldb_settings_storage_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/storage/storage_frontend_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/computed_hashes.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/content_hash_fetcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/content_hash_reader.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_protocols.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/file_reader.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/file_reader_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/image_loader.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/value_store/leveldb_value_store.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/value_store/leveldb_value_store_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/value_store/value_store_frontend_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/verified_contents.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/verified_contents_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_l10n_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_l10n_util_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_paths.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_resource.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_resource_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/file_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/file_util_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/background_info.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/icons_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/module_system_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/default_shell_browser_main_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_extension_system.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
hirono
PTAL the CL? Thank you!
6 years, 3 months ago (2014-09-03 13:12:54 UTC) #2
fukino
On 2014/09/03 13:12:54, hirono wrote: > PTAL the CL? Thank you! lgtm!
6 years, 3 months ago (2014-09-04 03:28:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/535673004/1
6 years, 3 months ago (2014-09-04 03:40:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as bb6eb95d5d4c9ba0a2c3a24a168359c62d67ab95
6 years, 3 months ago (2014-09-04 07:32:09 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:30:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0da5098d7e901bef3770f316c44e480e7087803d
Cr-Commit-Position: refs/heads/master@{#293281}

Powered by Google App Engine
This is Rietveld 408576698