Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/test/data/nacl/manifest_file/irt_manifest_file_test.cc

Issue 535643005: Fix build failure on linux_arm_cross_compile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/nacl/manifest_file/irt_manifest_file_test.cc
diff --git a/chrome/test/data/nacl/manifest_file/irt_manifest_file_test.cc b/chrome/test/data/nacl/manifest_file/irt_manifest_file_test.cc
index c29dc83d838a342a1508accb69dbf12e0e012ab7..db4bc549a214a58a6465e49ca075a38f5f656c13 100644
--- a/chrome/test/data/nacl/manifest_file/irt_manifest_file_test.cc
+++ b/chrome/test/data/nacl/manifest_file/irt_manifest_file_test.cc
@@ -8,6 +8,7 @@
// Test for resource open before PPAPI initialization.
//
+#include <pthread.h>
#include <stdio.h>
#include <string.h>
@@ -150,15 +151,16 @@ class TestInstance : public pp::Instance {
return;
}
+ pthread_t thread;
// We test the manifest routines again after PPAPI has initialized to
// ensure that they still work.
//
// irt_open_resource() isn't allowed to be called on the main thread once
// pepper starts, so these tests must happen on a background thread.
- pthread_create(&thread_, NULL, &RunTestsOnBackgroundThread, NULL);
+ //
+ // TODO(teravest): Check the return value here.
+ pthread_create(&thread, NULL, &RunTestsOnBackgroundThread, NULL);
}
- private:
- pthread_t thread_;
};
class TestModule : public pp::Module {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698