Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 535643005: Fix build failure on linux_arm_cross_compile. (Closed)

Created:
6 years, 3 months ago by teravest
Modified:
6 years, 3 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix build failure on linux_arm_cross_compile. I recently added a test that uses pthread_t without including the pthread.h header. This appears to be causing failures on the linux_arm_cross_compile bot. BUG=394130 Committed: https://crrev.com/41fb6e1fed25724195f67fb6046b3f7d13085d43 Cr-Commit-Position: refs/heads/master@{#293561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/test/data/nacl/manifest_file/irt_manifest_file_test.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
teravest
6 years, 3 months ago (2014-09-05 13:06:30 UTC) #2
Mark Seaborn
LGTM, thanks. How about setting BUG=394130?
6 years, 3 months ago (2014-09-05 14:20:32 UTC) #3
teravest
On 2014/09/05 14:20:32, Mark Seaborn wrote: > LGTM, thanks. How about setting BUG=394130? Done.
6 years, 3 months ago (2014-09-05 14:22:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/535643005/1
6 years, 3 months ago (2014-09-05 14:29:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/5704)
6 years, 3 months ago (2014-09-05 16:24:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/535643005/1
6 years, 3 months ago (2014-09-05 16:32:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8a1cf0ff697270f39c43ad664097b05eb32ad96a
6 years, 3 months ago (2014-09-05 18:43:23 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:40:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41fb6e1fed25724195f67fb6046b3f7d13085d43
Cr-Commit-Position: refs/heads/master@{#293561}

Powered by Google App Engine
This is Rietveld 408576698